gildas: init at 201806_a #41929
Merged
gildas: init at 201806_a #41929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @bzizou |
ryantm
requested changes
Jun 14, 2018
| make install | ||
| ''; | ||
|
|
||
| installPhase='' |
There was a problem hiding this comment.
Can this be moved to the postInstallPhase? Then it looks like the standard installPhase can call make install, which is currently in the buildPhase.
Gildas' uv_fit task segfaults when it uses OpenBLAS. Use internal LAPACK version instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR provides a package for Gildas, a collection of software for radio-astronomy. It's a re-submission of PR #27138 with an updated upstream version (201806_a), Python support
and OpenBLAS support.The package has been tested on Linux and Darwin.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)