Add i128 compiler-rt div/mul support #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiehuis
commented
Jun 13, 2018
| fn test__muloti4(a: i128, b: i128, expected: i128, expected_overflow: c_int) void { | ||
| var overflow: c_int = undefined; | ||
| const x = __muloti4(a, b, &overflow); | ||
| assert(overflow == expected_overflow and (overflow != 0 or x == expected)); |
There was a problem hiding this comment.
A double-check that this is equivalent would be nice, can't think right now.
https://github.com/llvm-mirror/compiler-rt/blob/9008dc9a4e6c3ac1eb7cdd910c8f74099420d911/test/builtins/Unit/muloti4_test.c
There was a problem hiding this comment.
I would have thought: overflow == expected_overflow and (expected_overflow == 0 or x == expected)
(change the 2nd overflow to expected_overflow)
I believe it is, since there is a 128 bit value as a return value. Here's the commit to follow example of: ec2a81a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Haven't tested on windows. I wonder if the udivmodti4 abi issue is relevant? Also, I am using these in a BigRational implementation so will wait until I'm happy there before doing anything here.