Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: fix substitution of /bin/rm #41930

Merged
merged 1 commit into from Jun 13, 2018
Merged

zfs: fix substitution of /bin/rm #41930

merged 1 commit into from Jun 13, 2018

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Jun 13, 2018 •
edited

Motivation for this change
zfs-share.service: Executable /bin/rm missing, skipping: No such file or directory
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zfs

Partial log (click to expand)

shrinking /nix/store/dqh4jx9nqqfv2l62ny8da7aw1m43rbbi-zfs-user-0.7.9-lib/lib/libzfs.so.2.0.0
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dqh4jx9nqqfv2l62ny8da7aw1m43rbbi-zfs-user-0.7.9-lib/lib
patching script interpreter paths in /nix/store/dqh4jx9nqqfv2l62ny8da7aw1m43rbbi-zfs-user-0.7.9-lib
checking for references to /build in /nix/store/dqh4jx9nqqfv2l62ny8da7aw1m43rbbi-zfs-user-0.7.9-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/mvv96i0z7i4pw5ni71nhb5913295a9mq-zfs-user-0.7.9-dev
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mvv96i0z7i4pw5ni71nhb5913295a9mq-zfs-user-0.7.9-dev/lib
patching script interpreter paths in /nix/store/mvv96i0z7i4pw5ni71nhb5913295a9mq-zfs-user-0.7.9-dev
checking for references to /build in /nix/store/mvv96i0z7i4pw5ni71nhb5913295a9mq-zfs-user-0.7.9-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zfs

Partial log (click to expand)

strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1bh15z1h313sq87jr0rjv4acgiabx41s-zfs-user-0.7.9-lib/lib
patching script interpreter paths in /nix/store/1bh15z1h313sq87jr0rjv4acgiabx41s-zfs-user-0.7.9-lib
checking for references to /build in /nix/store/1bh15z1h313sq87jr0rjv4acgiabx41s-zfs-user-0.7.9-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/4ia3xvinmck6d8qd1by4cjd60fxl4gbg-zfs-user-0.7.9-dev
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ia3xvinmck6d8qd1by4cjd60fxl4gbg-zfs-user-0.7.9-dev/lib
patching script interpreter paths in /nix/store/4ia3xvinmck6d8qd1by4cjd60fxl4gbg-zfs-user-0.7.9-dev
checking for references to /build in /nix/store/4ia3xvinmck6d8qd1by4cjd60fxl4gbg-zfs-user-0.7.9-dev...
/nix/store/jg2ppsywl9qs3cgphmp44x635bak854g-zfs-user-0.7.9

@xeji
Copy link
Contributor

xeji commented Jun 13, 2018

@GrahamcOfBorg build linuxPackages.zfsStable linuxPackages.zfsUnstable

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.zfsStable, linuxPackages.zfsUnstable

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13582:3:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13582:16:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
while evaluating 'buildLinux' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13885:16, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13885:23:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:48:1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxPackages.zfsStable, linuxPackages.zfsUnstable

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/765wsxr6vs16kkhkbxzax3010r4v6xgx-zfs-kernel-2018-05-22-4.14.49
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/765wsxr6vs16kkhkbxzax3010r4v6xgx-zfs-kernel-2018-05-22-4.14.49/lib  /nix/store/765wsxr6vs16kkhkbxzax3010r4v6xgx-zfs-kernel-2018-05-22-4.14.49/libexec
patching script interpreter paths in /nix/store/765wsxr6vs16kkhkbxzax3010r4v6xgx-zfs-kernel-2018-05-22-4.14.49
checking for references to /build in /nix/store/765wsxr6vs16kkhkbxzax3010r4v6xgx-zfs-kernel-2018-05-22-4.14.49...
/nix/store/4rrwpbb96ydq2k0gcx3g6aap1r8rlanp-zfs-kernel-0.7.9-4.14.49
/nix/store/765wsxr6vs16kkhkbxzax3010r4v6xgx-zfs-kernel-2018-05-22-4.14.49

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages.zfsStable, linuxPackages.zfsUnstable

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kmd02rsaal0asavi1dyk63srh8771gbk-zfs-kernel-2018-05-22-4.14.49
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kmd02rsaal0asavi1dyk63srh8771gbk-zfs-kernel-2018-05-22-4.14.49/lib  /nix/store/kmd02rsaal0asavi1dyk63srh8771gbk-zfs-kernel-2018-05-22-4.14.49/libexec
patching script interpreter paths in /nix/store/kmd02rsaal0asavi1dyk63srh8771gbk-zfs-kernel-2018-05-22-4.14.49
checking for references to /build in /nix/store/kmd02rsaal0asavi1dyk63srh8771gbk-zfs-kernel-2018-05-22-4.14.49...
/nix/store/9ag9hk24i4inm0ia1bk2x0ci2pajig8k-zfs-kernel-0.7.9-4.14.49
/nix/store/kmd02rsaal0asavi1dyk63srh8771gbk-zfs-kernel-2018-05-22-4.14.49

@xeji xeji merged commit 27e7143 into NixOS:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woffs @GrahamcOfBorg @xeji