Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell generic-builder: Use separate setup db in more cases #41932

Merged
merged 1 commit into from Jun 13, 2018
Merged

haskell generic-builder: Use separate setup db in more cases #41932

merged 1 commit into from Jun 13, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jun 13, 2018 •
edited

Motivation for this change

Use for cross and GHCJS whether or not there are setup depends.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @ElvishJerricco

@Ericson2314
haskell generic-builder: Use separate setup db in more cases
529a0f7 
Use for cross and GHCJS whether or not there are setup depends.
@Ericson2314 Ericson2314 requested a review from peti as a code owner June 13, 2018 15:34
@matthewbauer matthewbauer merged commit b2a76b6 into NixOS:master Jun 13, 2018
@ElvishJerricco
Copy link
Contributor

Why don't we just always use a separate db for setup? I'm not sure, but I don't think Cabal will give other components' build-depends to Setup.hs, so I don't think we'd be breaking anything by not providing them.

@Ericson2314 Ericson2314 deleted the fix-setup-depends branch June 13, 2018 17:39
@Ericson2314
Copy link
Member Author

@ElvishJerricco I recall that will break a bunch of lousy packages that predate custom-setup, but maybe Hackage has largely been fixed re those things? Let's test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees

@matthewbauer matthewbauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @ElvishJerricco @matthewbauer