pythonPackages.cmd2: 0.8.0 -> 0.9.1 #41934

teto · 2018-06-13T16:29:05Z

Motivation for this change

Many new features in cmd2 (subcommands/argparse support...)

The problem is that cmd2 dropped python support so I think we should keep both python2 compatible version (0.8.X) and the newest one. Is there any example of this ?

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-06-13T22:34:14Z

Ipython does the same:

ipython = if isPy27 then self.ipython_5 else self.ipython_6;

Mic92 · 2018-06-13T22:35:34Z

pkgs/development/python-modules/wcwidth/default.nix

+    version = "0.1.7";
+
+    src = fetchurl {
+      url = "mirror://pypi/w/wcwidth/${name}.tar.gz";


fetchPypi instead of fetchurl

teto · 2018-06-14T12:23:08Z

done

teto · 2018-06-14T12:51:54Z

name of the package is cmd2; the versions are respectively 0.8 and 0.9 so I believe cmd2_8 is better ? 2018-06-14 21:40 GMT+09:00 Frederik Rietdijk <notifications@github.com>:

…

***@***.**** commented on this pull request. ------------------------------ In pkgs/top-level/python-packages.nix <#41934 (comment)>: > @@ -9142,7 +9142,9 @@ in { cachetools_1 = callPackage ../development/python-modules/cachetools/1.nix {}; cachetools = callPackage ../development/python-modules/cachetools {}; - cmd2 = callPackage ../development/python-modules/cmd2 {}; + cmd2_8 = callPackage ../development/python-modules/cmd2/old.nix {}; cmd_2_8 cmd_2_9 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#41934 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2FOumV-lO5kcDvJsbvZm5ebXpE0o6Eks5t8lmogaJpZM4UmiDD> .

FRidh · 2018-06-14T12:53:36Z

name of the package is cmd2; the versions are respectively 0.8 and 0.9 so I believe cmd2_8 is better ?

Yes I just realized after my comment. It's a bit messy in this situation.

...which is the last one with python2 support until ~ august 2018

teto · 2018-06-18T09:56:38Z

should I move it to staging considering the number of rebuilds (kina impressed, must be the wcwidth change) ?

Mic92 · 2018-06-19T07:08:24Z

No master should be ok.

xeji · 2018-07-14T19:44:21Z

@GrahamcOfBorg build python36Packages.cmd2_9 python36Packages.cmd2_8 python27Packages.cmd2_8

GrahamcOfBorg · 2018-07-14T19:44:52Z

Success on x86_64-linux (full log)

Attempted: python36Packages.cmd2_9, python36Packages.cmd2_8, python27Packages.cmd2_8

Partial log (click to expand)

.......................                                                  [ 60%]
tests/test_parsing.py .................................................. [ 72%]
.................................................................        [ 87%]
tests/test_pyscript.py ........................                          [ 93%]
tests/test_transcript.py ...........................                     [100%]

==================== 407 passed, 10 skipped in 1.72 seconds ====================
/nix/store/gajy9rwljig2x7kq4k7c3h437v00r6xz-python3.6-cmd2-0.9.1
/nix/store/pv2frp0bq8xwa3fi3pxa7dqd7x9vc9vs-python3.6-cmd2-0.8.0
/nix/store/01j34rdk3hjlbbcara52y0986xnds7hv-python2.7-cmd2-0.8.0

GrahamcOfBorg · 2018-07-14T19:45:22Z

Success on aarch64-linux (full log)

Attempted: python36Packages.cmd2_9, python36Packages.cmd2_8, python27Packages.cmd2_8

Partial log (click to expand)

.......................                                                  [ 60%]
tests/test_parsing.py .................................................. [ 72%]
.................................................................        [ 87%]
tests/test_pyscript.py ........................                          [ 93%]
tests/test_transcript.py ...........................                     [100%]

==================== 407 passed, 10 skipped in 7.83 seconds ====================
/nix/store/8ywxh437i4svh6jg9lzak8j4hxxcs4aq-python3.6-cmd2-0.9.1
/nix/store/0py9v84j2q3k4g5f7qmhzp5jari7r6wa-python3.6-cmd2-0.8.0
/nix/store/qf4ngs2xb4pz2qm6bk8hx5idywjbkdvm-python2.7-cmd2-0.8.0

GrahamcOfBorg · 2018-07-14T19:48:25Z

Success on x86_64-darwin (full log)

Attempted: python36Packages.cmd2_9, python36Packages.cmd2_8, python27Packages.cmd2_8

Partial log (click to expand)

Installing collected packages: cmd2
Successfully installed cmd2-0.9.1
/private/tmp/nix-build-python3.6-cmd2-0.9.1.drv-0/cmd2-0.9.1
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/igf8qk59q7jnmy52rc4fgnw2z3brbrs9-python3.6-cmd2-0.9.1/lib
patching script interpreter paths in /nix/store/igf8qk59q7jnmy52rc4fgnw2z3brbrs9-python3.6-cmd2-0.9.1
/nix/store/igf8qk59q7jnmy52rc4fgnw2z3brbrs9-python3.6-cmd2-0.9.1
/nix/store/v406iap6hnmqq5x9shckvvd3xqgjsbiq-python3.6-cmd2-0.8.0
/nix/store/wp1rwm12day9nv6121fxzdqgymipnfp6-python2.7-cmd2-0.8.0

teto requested a review from FRidh as a code owner June 13, 2018 16:29

teto changed the title ~~Cmd2 0.9.1~~ [RFC] Cmd2 0.9.1 Jun 13, 2018

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jun 13, 2018

Mic92 reviewed Jun 13, 2018

View reviewed changes

pythonPackages.wcwith: 0.1.6 -> 0.1.7

d62a355

teto force-pushed the cmd2_0.9.1 branch 2 times, most recently from 872b8e9 to 65b15ba Compare June 14, 2018 09:47

GrahamcOfBorg added 8.has: package (new) 10.rebuild-linux: 101-500 and removed 10.rebuild-linux: 11-100 labels Jun 14, 2018

teto changed the title ~~[RFC] Cmd2 0.9.1~~ [RDY] Cmd2 0.9.1 Jun 14, 2018

teto added 2 commits June 15, 2018 03:46

python3Packages.cmd2: 0.8.0 -> 0.9.1

bb47fd0

pythonPackages.cmd2: keep 0.8 version

65b15ba

...which is the last one with python2 support until ~ august 2018

FRidh changed the title ~~[RDY] Cmd2 0.9.1~~ pythonPackages.cmd2: 0.8.0 -> 0.9.1 Jul 10, 2018

xeji merged commit 27eb3c2 into NixOS:master Jul 14, 2018

teto deleted the cmd2_0.9.1 branch September 5, 2021 00:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.cmd2: 0.8.0 -> 0.9.1 #41934

pythonPackages.cmd2: 0.8.0 -> 0.9.1 #41934

teto commented Jun 13, 2018 •

edited

Mic92 commented Jun 13, 2018

Mic92 Jun 13, 2018 •

edited

teto commented Jun 14, 2018

teto commented Jun 14, 2018 via email

FRidh commented Jun 14, 2018

teto commented Jun 18, 2018

Mic92 commented Jun 19, 2018

xeji commented Jul 14, 2018

GrahamcOfBorg commented Jul 14, 2018

GrahamcOfBorg commented Jul 14, 2018

GrahamcOfBorg commented Jul 14, 2018

pythonPackages.cmd2: 0.8.0 -> 0.9.1 #41934

pythonPackages.cmd2: 0.8.0 -> 0.9.1 #41934

Conversation

teto commented Jun 13, 2018 • edited

Motivation for this change

Things done

Mic92 commented Jun 13, 2018

Mic92 Jun 13, 2018 • edited

Choose a reason for hiding this comment

teto commented Jun 14, 2018

teto commented Jun 14, 2018 via email

FRidh commented Jun 14, 2018

teto commented Jun 18, 2018

Mic92 commented Jun 19, 2018

xeji commented Jul 14, 2018

GrahamcOfBorg commented Jul 14, 2018

GrahamcOfBorg commented Jul 14, 2018

GrahamcOfBorg commented Jul 14, 2018

teto commented Jun 13, 2018 •

edited

Mic92 Jun 13, 2018 •

edited