Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.2.2 -> 0.3.0 #41922

Closed
wants to merge 1 commit into from
Closed

neovim: 0.2.2 -> 0.3.0 #41922

wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Jun 13, 2018 •
edited

Changelog at neovim/neovim@44c6deb

Fixed missing manpage.
Remove the indirection for the python interpreters (why was it there in the first place ? I am afraid there is a good reason but I don't know it).

Sadly we still can't run the tests but if anyone is interested, this used to be possible with
#33903 (review)

Motivation for this change

Neovim is freaking cool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 13, 2018

@GrahamcOfBorg build neovim

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: neovim

Partial log (click to expand)

these derivations will be built:
  /nix/store/r8w78gi8x5144ns5zlj8zn8iw48wk3my-neovim-0.3.0.drv
building '/nix/store/r8w78gi8x5144ns5zlj8zn8iw48wk3my-neovim-0.3.0.drv'...
/nix/store/60zkc8xm499147v33wj9yfw3gvarxkkm-neovim-0.3.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim

Partial log (click to expand)

stack traceback:
        [C]: in function 'match'
        /build/source/src/nvim/generators/gen_declarations.lua:255: in main chunk
        [C]: at 0x00405660
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:235: src/nvim/auto/eval.c.generated.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:2865: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/g76lcg5l56fza9jc4zdb46s088qq45a8-neovim-unwrapped-0.3.0.drv' failed with exit code 2
cannot build derivation '/nix/store/ix69iyynf6iis6kbmpnvx550plfjb0n0-neovim-0.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ix69iyynf6iis6kbmpnvx550plfjb0n0-neovim-0.3.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 13, 2018

neovim was already upgraded to 0.3.0 in #41873. Closing this as duplicate.

@xeji xeji closed this Jun 13, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neovim

Partial log (click to expand)

copying path '/nix/store/5q3s7vgbx7ldnnh2q4mjnsnxkpi88gc9-python3.6-neovim-0.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/2803z50pzlzb8yww4aq834nv6pf3rlc4-ruby2.4.4-msgpack-1.2.4' from 'https://cache.nixos.org'...
copying path '/nix/store/84rc2fa3slz99ygsfavy7mdr5klysszf-python3-3.6.5-env' from 'https://cache.nixos.org'...
copying path '/nix/store/wv1jyd4ql89g8kf7y93wd4cnf2yzhsxp-ruby2.4.4-neovim-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/fxvisrcfka11633834djb88ls3r32xwy-unibilium-2.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/z3s4lqj2z8lbwgddaicscpv1lr3m7h1k-neovim-ruby-env' from 'https://cache.nixos.org'...
copying path '/nix/store/ikm2lkimfcbvaggzm1r2d5iaijj3g01y-xsel-unstable-2016-09-02' from 'https://cache.nixos.org'...
copying path '/nix/store/xr6hr01ym9adgj7hjicjhngingbfdwr6-neovim-unwrapped-0.3.0' from 'https://cache.nixos.org'...
building '/nix/store/lnym5fxpxg1v53llpi34y1g7pn0q89jx-neovim-0.3.0.drv'...
/nix/store/wv82s7caxz2z50fis5k5c6q0kskwjalg-neovim-0.3.0

@teto
neovim: 0.2.2 -> 0.3.0
552a06b 
Changelog at neovim/neovim@44c6deb

Fixed missing manpage.
Remove the indirection for the python interpreters
@teto teto deleted the neovim0.3 branch June 14, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @xeji @GrahamcOfBorg