Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nghttp2: 1.31.0 -> 1.32.0 #40943

Merged
merged 1 commit into from May 22, 2018
Merged

nghttp2: 1.31.0 -> 1.32.0 #40943

merged 1 commit into from May 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 22, 2018

1.31.1 has security fix for CVE-2018-1000168:

https://nghttp2.org/blog/2018/04/12/nghttp2-v1-31-1/

Quickly following our update to 1.31.0,
let's grab latest and in particular get
the security fix in 1.31.1.

I've only build-tested nghttp2 itself.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from lukateras May 22, 2018 22:30
@dtzWill
Copy link
Member Author

dtzWill commented May 22, 2018

@GrahamcOfBorg build nghttp2
@GrahamcOfBorg test nghttpx

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dijqnm93i711w20k41a735dvfxpxw3jz-nghttp2-1.32.0-dev/lib
patching script interpreter paths in /nix/store/dijqnm93i711w20k41a735dvfxpxw3jz-nghttp2-1.32.0-dev
checking for references to /build in /nix/store/dijqnm93i711w20k41a735dvfxpxw3jz-nghttp2-1.32.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib
shrinking /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib/lib/libnghttp2.so.14.16.2
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib/lib
patching script interpreter paths in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib
checking for references to /build in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib...

@lukateras
Copy link
Member

@GrahamcOfBorg test nghttp2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/bzfh65bfsva72qp4lidw5km2l1kabb8d-nghttp2-1.32.0-dev/lib
patching script interpreter paths in /nix/store/bzfh65bfsva72qp4lidw5km2l1kabb8d-nghttp2-1.32.0-dev
checking for references to /build in /nix/store/bzfh65bfsva72qp4lidw5km2l1kabb8d-nghttp2-1.32.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/50pj21xzq8siwrl0pix9gihsanhzvzic-nghttp2-1.32.0-lib
shrinking /nix/store/50pj21xzq8siwrl0pix9gihsanhzvzic-nghttp2-1.32.0-lib/lib/libnghttp2.so.14.16.2
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/50pj21xzq8siwrl0pix9gihsanhzvzic-nghttp2-1.32.0-lib/lib
patching script interpreter paths in /nix/store/50pj21xzq8siwrl0pix9gihsanhzvzic-nghttp2-1.32.0-lib
checking for references to /build in /nix/store/50pj21xzq8siwrl0pix9gihsanhzvzic-nghttp2-1.32.0-lib...
/nix/store/dx2nw0nbvm9m68wjchcnaba2rfqblj27-nghttp2-1.32.0-bin

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.nghttp2

Partial log (click to expand)

Cannot nix-instantiate `tests.nghttp2' because:
�[31;1merror:�[0m attribute 'nghttp2' in selection path 'tests.nghttp2' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.nghttp2

Partial log (click to expand)

Cannot nix-instantiate `tests.nghttp2' because:
error: attribute 'nghttp2' in selection path 'tests.nghttp2' not found

@dtzWill
Copy link
Member Author

dtzWill commented May 22, 2018

Oops, thanks for mentioning the security fix @xeji (#36462 (comment)) sorry for not getting to it earlier! :)

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nghttp2

Partial log (click to expand)

patching script interpreter paths in /nix/store/z66pxjjsikc474rbjlgsn7710dvvwbwh-nghttp2-1.32.0-bin
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/58161wfkgfkr99ms6avbycba44a8p62b-nghttp2-1.32.0
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mbkaq3f67gnpkjzv65py4zsvvy7qpngj-nghttp2-1.32.0-dev/lib
patching script interpreter paths in /nix/store/mbkaq3f67gnpkjzv65py4zsvvy7qpngj-nghttp2-1.32.0-dev
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kxd5dgmw0mcjlhn6a6d8v3vnyzmnazpp-nghttp2-1.32.0-lib/lib
patching script interpreter paths in /nix/store/kxd5dgmw0mcjlhn6a6d8v3vnyzmnazpp-nghttp2-1.32.0-lib
/nix/store/z66pxjjsikc474rbjlgsn7710dvvwbwh-nghttp2-1.32.0-bin

@lukateras lukateras merged commit 3203c12 into NixOS:master May 22, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

/nix/store/dx2nw0nbvm9m68wjchcnaba2rfqblj27-nghttp2-1.32.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nghttp2

Partial log (click to expand)

patching script interpreter paths in /nix/store/z66pxjjsikc474rbjlgsn7710dvvwbwh-nghttp2-1.32.0-bin
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/58161wfkgfkr99ms6avbycba44a8p62b-nghttp2-1.32.0
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/mbkaq3f67gnpkjzv65py4zsvvy7qpngj-nghttp2-1.32.0-dev/lib
patching script interpreter paths in /nix/store/mbkaq3f67gnpkjzv65py4zsvvy7qpngj-nghttp2-1.32.0-dev
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kxd5dgmw0mcjlhn6a6d8v3vnyzmnazpp-nghttp2-1.32.0-lib/lib
patching script interpreter paths in /nix/store/kxd5dgmw0mcjlhn6a6d8v3vnyzmnazpp-nghttp2-1.32.0-lib
/nix/store/z66pxjjsikc474rbjlgsn7710dvvwbwh-nghttp2-1.32.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dijqnm93i711w20k41a735dvfxpxw3jz-nghttp2-1.32.0-dev/lib
patching script interpreter paths in /nix/store/dijqnm93i711w20k41a735dvfxpxw3jz-nghttp2-1.32.0-dev
checking for references to /build in /nix/store/dijqnm93i711w20k41a735dvfxpxw3jz-nghttp2-1.32.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib
shrinking /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib/lib/libnghttp2.so.14.16.2
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib/lib
patching script interpreter paths in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib
checking for references to /build in /nix/store/hbbks12hhcv7v6lhc2wf9nbp3d9hg791-nghttp2-1.32.0-lib...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nghttpx

Partial log (click to expand)

webserver# [  145.668411] dhcpcd[661]: eth0: adding default route via 10.0.2.2
webserver: exit status 0
test script finished in 147.97s
cleaning up
killing proxy (pid 593)
killing client (pid 605)
killing webserver (pid 617)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/i7sbz05mgbmmkhhq22ras9rf5hbdp79g-vm-test-run-nghttpx

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nghttpx

Partial log (click to expand)

proxy# [   18.233192] nscd[759]: 759 monitoring directory `/etc` (2)
client: exit status 0
test script finished in 19.72s
cleaning up
killing webserver (pid 627)
killing proxy (pid 640)
killing client (pid 653)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/mdksx14y457y0g8d0d8gacijx32hk12p-vm-test-run-nghttpx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @lukateras