Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloaty: 2017-10-05 -> 2018-05-22 #40940

Merged
merged 1 commit into from May 22, 2018
Merged

bloaty: 2017-10-05 -> 2018-05-22 #40940

merged 1 commit into from May 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 22, 2018

  • add zlib dep (cmake tries to find it, provide it JIC)
  • no need to populate with path to c++filt, handled internally now
  • continue to copy ourselves, new install target isn't ready yet
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
bloaty: 2017-10-05 -> 2018-05-22
b7fe62d 
* add zlib dep (cmake tries to find it, provide it JIC)
* no need to populate with path to c++filt, handled internally now
* continue to copy ourselves, new install target isn't ready yet
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bloaty

Partial log (click to expand)


100% tests passed, 0 tests failed out of 5

Total Test time (real) =   1.27 sec
installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6s5bvs1g30hmnvaw7lcayjfpgs5gc09p-bloaty-2018-05-22/lib  /nix/store/6s5bvs1g30hmnvaw7lcayjfpgs5gc09p-bloaty-2018-05-22/bin
patching script interpreter paths in /nix/store/6s5bvs1g30hmnvaw7lcayjfpgs5gc09p-bloaty-2018-05-22
/nix/store/6s5bvs1g30hmnvaw7lcayjfpgs5gc09p-bloaty-2018-05-22

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bloaty

Partial log (click to expand)

Total Test time (real) =   2.28 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22
shrinking /nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22/bin/bloaty
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22/lib  /nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22/bin
patching script interpreter paths in /nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22
checking for references to /build in /nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22...
/nix/store/irnrwraxhdw0wk1x2mp649wcn2ws5ncb-bloaty-2018-05-22

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bloaty

Partial log (click to expand)

Total Test time (real) =   1.21 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22
shrinking /nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22/bin/bloaty
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22/lib  /nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22/bin
patching script interpreter paths in /nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22
checking for references to /build in /nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22...
/nix/store/8i5l0i03011pwjvcr3g6wn4sz171xbi0-bloaty-2018-05-22

@lukateras lukateras merged commit 8343b0a into NixOS:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @lukateras