Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite{,-analyzer}: use the same src #40945

Merged
merged 3 commits into from May 23, 2018
Merged

sqlite{,-analyzer}: use the same src #40945

merged 3 commits into from May 23, 2018

Conversation

lukateras
Copy link
Member

veprbl
veprbl reviewed May 22, 2018
View reviewed changes
pkgs/development/libraries/sqlite/default.nix Outdated

configureFlags = [ "--enable-threadsafe" ] ++ optional interactive "--enable-readline";
configureFlags = [
"--disable-tcl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this contradict nativeBuildInputs = [ tcl ]; that you added just a few lines above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, tcl is required anyway. This flag is used to decide whether to build libtclsqlite.so or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it could use a comment.

@lukateras
Copy link
Member Author

@GrahamcOfBorg build sqlite sqlite-analyzer

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sqlite, sqlite-analyzer

Partial log (click to expand)

separating debug info from /nix/store/gyfjjv55dmvn2ccpiwz6pzm2dwzw72k3-sqlite-3.23.1/lib/libsqlite3.so.0.8.6 (build ID 1bb9d21e224752051b21895f5ee866490d44af2d)
shrinking RPATHs of ELF executables and libraries in /nix/store/gyfjjv55dmvn2ccpiwz6pzm2dwzw72k3-sqlite-3.23.1
shrinking /nix/store/gyfjjv55dmvn2ccpiwz6pzm2dwzw72k3-sqlite-3.23.1/lib/libsqlite3.so.0.8.6
patching script interpreter paths in /nix/store/gyfjjv55dmvn2ccpiwz6pzm2dwzw72k3-sqlite-3.23.1
checking for references to /build in /nix/store/gyfjjv55dmvn2ccpiwz6pzm2dwzw72k3-sqlite-3.23.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/6vz4kn1wfjlaa37dmq83zvf7s1ra5d8b-sqlite-3.23.1-debug
patching script interpreter paths in /nix/store/6vz4kn1wfjlaa37dmq83zvf7s1ra5d8b-sqlite-3.23.1-debug
checking for references to /build in /nix/store/6vz4kn1wfjlaa37dmq83zvf7s1ra5d8b-sqlite-3.23.1-debug...
/nix/store/z1l5bbkw0xlzlm6n7sdfbf727j598sgq-sqlite-3.23.1-bin
/nix/store/2f8kngy86mj98jzxfkj4811yjz4z07js-sqlite-analyzer-3.23.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sqlite, sqlite-analyzer

Partial log (click to expand)

separating debug info from /nix/store/v2xbqf26dg949pdkzv3m1x1v46qf2qm8-sqlite-3.23.1/lib/libsqlite3.so.0.8.6 (build ID f516aecd3fdf902cf3f69ba2333fcf38dac64a42)
shrinking RPATHs of ELF executables and libraries in /nix/store/v2xbqf26dg949pdkzv3m1x1v46qf2qm8-sqlite-3.23.1
shrinking /nix/store/v2xbqf26dg949pdkzv3m1x1v46qf2qm8-sqlite-3.23.1/lib/libsqlite3.so.0.8.6
patching script interpreter paths in /nix/store/v2xbqf26dg949pdkzv3m1x1v46qf2qm8-sqlite-3.23.1
checking for references to /build in /nix/store/v2xbqf26dg949pdkzv3m1x1v46qf2qm8-sqlite-3.23.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/bwy43p23isd93j4gp4wvmi3fsggyyncx-sqlite-3.23.1-debug
patching script interpreter paths in /nix/store/bwy43p23isd93j4gp4wvmi3fsggyyncx-sqlite-3.23.1-debug
checking for references to /build in /nix/store/bwy43p23isd93j4gp4wvmi3fsggyyncx-sqlite-3.23.1-debug...
/nix/store/clvv6n6jw92gc1zxjy8z96aimnv1m9qw-sqlite-3.23.1-bin
/nix/store/wnzfc00cb17cbybzydgvfhklvhqqdj29-sqlite-analyzer-3.23.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sqlite, sqlite-analyzer

Partial log (click to expand)

cannot build derivation '/nix/store/z6qwflplis5194pn8d04bh2x94nl3jjq-unzip-6.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hb4i486vzyk6awrl02n60631byh212rw-openssl-1.0.2o.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/yw20pb6q84kklssw2w318im2csf9dv3x-pkg-config-0.29.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/nkdqrgrjz6vd075a49klb8zlw1bs9cy8-libssh2-1.8.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/admrxn9b1slqc5wih8iq59hv83h041xf-nghttp2-1.24.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/n0hac5fh777kcqsphixczjs459rj3nf4-curl-7.60.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/jijyw5dk8whi6g7fmdcwqpw1id5dvwa9-source.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/yn0ayy81lav77yfx64cf5d5b06flvkh1-sqlite-3.23.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/y6a2lp00197kqim7d557v15fbp09jmja-sqlite-analyzer-3.23.1.drv': 4 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/y6a2lp00197kqim7d557v15fbp09jmja-sqlite-analyzer-3.23.1.drv', '/nix/store/yn0ayy81lav77yfx64cf5d5b06flvkh1-sqlite-3.23.1.drv' failed

dezgeg
dezgeg reviewed May 23, 2018
View reviewed changes
pkgs/development/libraries/sqlite/default.nix Outdated
configureFlags = [
"--disable-tcl"
"--enable-threadsafe"
(optional interactive "--enable-readline")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces nested lists like:

[ "--disable-tcl" "--enable-threadsafe" [] ]

or

[ "--disable-tcl" "--enable-threadsafe" ["--enable-readline"] ]

In the end when converted to shell environment variables the result is the same, but it's a bit confusing IMO.

@dezgeg
Copy link
Contributor

dezgeg commented May 23, 2018

Neat, thank you!

@xeji
Copy link
Contributor

xeji commented May 23, 2018

LGTM. Much cleaner now.

@lukateras lukateras merged commit e28a586 into NixOS:staging May 23, 2018
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request May 27, 2018
@dtzWill
Revert "sqlite{,-analyzer}: use the same src (NixOS#40945)"
d926d2b 
This reverts commit e28a586.
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request May 27, 2018
@dtzWill
Revert "sqlite{,-analyzer}: use the same src (NixOS#40945)"
232bc96 
This reverts commit e28a586.
lukateras added a commit that referenced this pull request May 27, 2018
@lukateras
Merge pull request #41128 from dtzWill/fix/sqlite-build-opts
dac633f 
Revert "sqlite{,-analyzer}: use the same src (#40945)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@dezgeg dezgeg dezgeg left review comments

@Synthetica9 Synthetica9 Synthetica9 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lukateras @GrahamcOfBorg @dezgeg @xeji @veprbl @Synthetica9