Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

springlobby: 0.255 -> 0.264 with buildFHSUserEnv #40946

Closed
wants to merge 2 commits into from
Closed

springlobby: 0.255 -> 0.264 with buildFHSUserEnv #40946

wants to merge 2 commits into from

Conversation

baracoder
Copy link
Contributor

Motivation for this change

This allows to drop the dependency on spring, which is
currently broken and to use spring versions downloaded by
springlobby instead

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@baracoder
springlobby: 0.255 -> 0.264 with buildFHSUserEnv
8d57674 
This allows to drop the dependency on spring, which is
currently broken and to use spring versions downloaded by
springlobby instead
@lukateras lukateras self-requested a review May 22, 2018 23:50
@jtojnar
Copy link
Contributor

jtojnar commented May 23, 2018

It would be preferable to fix spring instead.

@baracoder
Copy link
Contributor Author

Sorry for the clumsy commit. I don't have much experience with nix yet.

I would like to use this approach, since it allows to use multiple versions of the engine at the same time. Also at least in the past, I had problems with games running out of sync because it was compiled with a different compiler version.

Fixing the packaged spring engine is definitely worth a try, too.

@baracoder
Copy link
Contributor Author

Have opened a merge request to fix the spring package #41153

@baracoder
Copy link
Contributor Author

I guess it won't be merged, since it is open for more then a week without new input.

@baracoder baracoder closed this Jun 5, 2018
@baracoder baracoder deleted the springlobby-fhs branch November 11, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras Awaiting requested review from lukateras

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baracoder @jtojnar @GrahamcOfBorg @lukateras