Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.28.1 -> 0.30.0 #41036

Merged
merged 1 commit into from May 24, 2018
Merged

matrix-synapse: 0.28.1 -> 0.30.0 #41036

merged 1 commit into from May 24, 2018

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

Mainly some new features for getting GDPR consent of users: https://matrix.org/blog/2018/05/24/synapse-0-30-0-released-today/

Note: For some reason running the tests don't work on my machine, could someone who can do that initiate running them through @GrahamcOfBorg ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@florianjacob florianjacob mentioned this pull request May 24, 2018
Closed
@xeji
Copy link
Contributor

xeji commented May 24, 2018

@GrahamcOfBorg build matrix-synapse

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: matrix-synapse

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/lib  /nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin
patching script interpreter paths in /nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0
checking for references to /build in /nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0...
wrapping `/nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin/synapse_port_db'...
wrapping `/nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin/register_new_matrix_user'...
wrapping `/nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin/synctl'...
wrapping `/nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin/hash_password'...
wrapping `/nix/store/rkrwj1v0qr62kl5phycdkbdahvpp692d-matrix-synapse-0.30.0/bin/homeserver'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/lib  /nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin
patching script interpreter paths in /nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0
checking for references to /build in /nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0...
wrapping `/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin/hash_password'...
wrapping `/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin/homeserver'...
wrapping `/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin/register_new_matrix_user'...
wrapping `/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin/synapse_port_db'...
wrapping `/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0/bin/synctl'...
/nix/store/c8vgn3kcfc6wwkw19ivkdjchyk8mvly1-matrix-synapse-0.30.0

@xeji
Copy link
Contributor

xeji commented May 24, 2018

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

server_postgres: exit status 0
server_sqlite: running command: sync
server_sqlite: exit status 0
test script finished in 54.27s
cleaning up
killing server_postgres (pid 593)
killing server_sqlite (pid 605)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/dvnacnm4ws18gjasis9ajhhqn8rfmksa-vm-test-run-matrix-synapse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

server_sqlite: exit status 0
server_postgres: running command: sync
server_postgres: exit status 0
test script finished in 100.14s
cleaning up
killing server_sqlite (pid 627)
killing server_postgres (pid 640)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/vdnv3hzfys80kc3khka323vccnjyfahm-vm-test-run-matrix-synapse

@xeji xeji merged commit 3cfc90e into NixOS:master May 24, 2018
@florianjacob florianjacob deleted the matrix-synapse branch May 24, 2018 17:35
@pstn
Copy link
Contributor

pstn commented May 24, 2018

Can we backport that to stable at least as an optional package? GDPR compliance could be a very important feature. @xeji

@florianjacob
Copy link
Contributor Author

@pstn I found no breaking changes from current stable 0.28.1 to 0.29.1 and 0.30.0, so I don't think technical issues would block this.

Did not request backporting as at least I do not provide accounts on my synapse server to other people, and I actually just use the package from unstable.

srhb pushed a commit to srhb/nixpkgs that referenced this pull request May 25, 2018
@florianjacob @srhb
matrix-synapse: 0.28.1 -> 0.30.0
1dbc6e2 
Backport of NixOS#41036
(cherry picked from commit 429d81d)
@srhb srhb mentioned this pull request May 25, 2018
Merged
8 tasks
xeji pushed a commit that referenced this pull request May 25, 2018
@srhb @xeji
matrix-synapse: 0.28.1 -> 0.30.0 (#41075)
7655989 
Backport of #41036
(cherry picked from commit 429d81d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florianjacob @xeji @GrahamcOfBorg @pstn