Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-addons: fix dashboard & dns with proper imageDigest #41050

Closed
wants to merge 1 commit into from

Conversation

thpham
Copy link
Member

@thpham thpham commented May 24, 2018

Motivation for this change

when trying to provision my k8s cluster from nix-channel unstable, I got the following error.

error: anonymous function at /home/xxx/github/nixos/nixpkgs/pkgs/build-support/docker/default.nix:38:5 called without required argument 'imageDigest', at /home/xxx/github/nixos/nixpkgs/nixos/modules/services/cluster/kubernetes/dns.nix:8:22

It seem the imageDigest is now required. I download all the docker images affected and tested their digest with skopeo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@thpham thpham changed the title fix: kubernetes addons (dashboard/dns) with proper imageDigest kubernetes-addons: fix dashboard & dns with proper imageDigest May 24, 2018
@srhb srhb self-assigned this May 24, 2018
@srhb
Copy link
Contributor

srhb commented May 24, 2018

This was fixed in #40665. :)

@srhb srhb closed this May 24, 2018
@thpham
Copy link
Member Author

thpham commented May 24, 2018

@srhb sorry my bad, thanks

@thpham thpham deleted the fix/kubernetes-addons branch May 24, 2018 20:46
@srhb
Copy link
Contributor

srhb commented May 24, 2018

Nothing to be sorry about, appreciate the effort! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants