Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nheko: 0.4.0 -> 0.4.1 #41030

Merged
merged 2 commits into from May 24, 2018
Merged

nheko: 0.4.0 -> 0.4.1 #41030

merged 2 commits into from May 24, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented May 24, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1
shrinking /nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1/bin/nheko
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1/bin
patching script interpreter paths in /nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1
checking for references to /build in /nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1...
postPatchMkspecs
/nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1
shrinking /nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1/bin/nheko
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1/bin
patching script interpreter paths in /nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1
checking for references to /build in /nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1...
postPatchMkspecs
/nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1

@xeji
Copy link
Contributor

xeji commented May 24, 2018

let's see if this builds on darwin
@GrahamcOfBorg build nheko

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nheko

Partial log (click to expand)

  Add the installation prefix of "Qt5MacExtras" to CMAKE_PREFIX_PATH or set
  "Qt5MacExtras_DIR" to a directory containing one of the above files.  If
  "Qt5MacExtras" provides a separate development package or SDK, be sure it
  has been installed.


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-nheko-0.4.1.drv-0/source/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/ghixsn2x4i9n2fxzci9szbii4a49qd7d-nheko-0.4.1.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/ghixsn2x4i9n2fxzci9szbii4a49qd7d-nheko-0.4.1.drv' failed

@xeji
Copy link
Contributor

xeji commented May 24, 2018 •
edited

Did this build on Darwin before? (Can't find successful Darwin build on Hydra).
Anyway, please try to fix the Darwin build or restrict to platforms.linux.

@Ekleog
Copy link
Member Author

Ekleog commented May 24, 2018

It had never been built on darwin before AFAIK (at least not by ofborg, and I never received notification by hydra on darwin builds).

I've just tried to push a fix, hopefully that should make things build. Could you re-trigger a build? :)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1

@xeji
Copy link
Contributor

xeji commented May 24, 2018

@GrahamcOfBorg build nheko

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nheko

Partial log (click to expand)

[ 69%] Building CXX object CMakeFiles/nheko.dir/include/dialogs/moc_JoinRoom.cpp.o
[ 69%] Building CXX object CMakeFiles/nheko.dir/include/dialogs/moc_MemberList.cpp.o
[ 70%] Building CXX object CMakeFiles/nheko.dir/include/dialogs/moc_LeaveRoom.cpp.o
20 errors generated.
make[2]: *** [CMakeFiles/nheko.dir/build.make:2023: CMakeFiles/nheko.dir/src/notifications/ManagerMac.mm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/nheko.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
builder for '/nix/store/l8x5f9dyr50srn3h8czrihcn2jlarffv-nheko-0.4.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/l8x5f9dyr50srn3h8czrihcn2jlarffv-nheko-0.4.1.drv' failed

@xeji
Copy link
Contributor

xeji commented May 24, 2018

Thanks. Looks promising but I have no idea how to fix the new error. Unless you want to give it another try, I'd say we merge it as is and let whoever wants to use this on Darwin fix it.

@Ekleog
Copy link
Member Author

Ekleog commented May 24, 2018

Let's see if this does it, hopefully it will just work now :)

@xeji
Copy link
Contributor

xeji commented May 24, 2018

@GrahamcOfBorg build nheko

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nheko

Partial log (click to expand)

[ 67%] Building CXX object CMakeFiles/nheko.dir/include/dialogs/moc_ImageOverlay.cpp.o
[ 68%] Building CXX object CMakeFiles/nheko.dir/include/dialogs/moc_PreviewUploadOverlay.cpp.o
[ 68%] Building CXX object CMakeFiles/nheko.dir/include/dialogs/moc_InviteUsers.cpp.o
20 errors generated.
make[2]: *** [CMakeFiles/nheko.dir/build.make:2023: CMakeFiles/nheko.dir/src/notifications/ManagerMac.mm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/nheko.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
builder for '/nix/store/8fdmxz2pjwxn2v5x1pkpkp773if87lay-nheko-0.4.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/8fdmxz2pjwxn2v5x1pkpkp773if87lay-nheko-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1
shrinking /nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1/bin/nheko
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1/bin
patching script interpreter paths in /nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1
checking for references to /build in /nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1...
postPatchMkspecs
/nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1
shrinking /nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1/bin/nheko
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1/bin
patching script interpreter paths in /nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1
checking for references to /build in /nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1...
postPatchMkspecs
/nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/y591vfh4j410kgllrxph2yw4lvhl0kii-nheko-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/bcnas90ydf8333z1bx8fwq51bjjj8psr-nheko-0.4.1

@Ekleog
Copy link
Member Author

Ekleog commented May 24, 2018

Looks like it doesn't work… I've added a comment to push people who would want to fix this package on darwin onto the right track, and I'm running short on ideas for fixing this issue :/

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/gcm4b5c5k2d8vr02npbccpzh13yhd3fg-nheko-0.4.1

@xeji
Copy link
Contributor

xeji commented May 24, 2018

Thank you!

@xeji xeji merged commit a2d2a6e into NixOS:master May 24, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nheko

Partial log (click to expand)

/nix/store/hav02kkzljx1qw03jr2rlqw7cbj5n6gw-nheko-0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @xeji