Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua packages: add init.lua to modules search path #41023

Merged
merged 1 commit into from Jun 2, 2018
Merged

lua packages: add init.lua to modules search path #41023

merged 1 commit into from Jun 2, 2018

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented May 24, 2018

Motivation for this change

Some lua modules are loaded from directories and they need .../?/init.lua in LUA_PATH.

Currently luaposix is affected by this, example:

$ nix-shell -p luaPackages.luaposix
$ lua -e 'local posix = require "posix"'
lua: (command line):1: module 'posix' not found:
        no field package.preload['posix']
        no file '/nix/store/6ajbqh4d8gwsqc8bhhmbwh42pm8067lq-lua5.2-posix-34.0.4/share/lua/5.2/posix.lua'
        no file '/nix/store/7ri66nfliqwz9y5psnan20x7qhr79p4n-lua5.2-std.normalize-2.0.1/share/lua/5.2/posix.lua'
        no file '/nix/store/zirr21mk3bsfd5hhdcrrgfw32m2c44vb-lua5.2-std._debug-1.0/share/lua/5.2/posix.lua'
        no file '/nix/store/6ajbqh4d8gwsqc8bhhmbwh42pm8067lq-lua5.2-posix-34.0.4/lib/lua/5.2/posix.so'
        no file '/nix/store/6kqsclvf3acm3ivyf53cbq7p0j9lf114-lua5.2-bit32-5.3.0/lib/lua/5.2/posix.so'
stack traceback:
        [C]: in function 'require'
        (command line):1: in main chunk
        [C]: ?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit 4ca9f84 into NixOS:master Jun 2, 2018
@lblasc lblasc deleted the lua-path-fix branch June 4, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lblasc @matthewbauer @GrahamcOfBorg