Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 3.1.0 -> 3.2.0-beta2 #41051

Merged
merged 1 commit into from May 26, 2018
Merged

slack: 3.1.0 -> 3.2.0-beta2 #41051

merged 1 commit into from May 26, 2018

Conversation

benley
Copy link
Member

@benley benley commented May 24, 2018

I know this says it's a beta verison, but

  • This is the version they're distributing on slack.com/download for linux
  • The previous releases were "beta" too, they just didn't mention it in the version string
Motivation for this change

New upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@benley
slack: 3.1.0 -> 3.2.0-beta2
39be434 
I know this says it's a beta verison, but
  - This is the version they're distributing on slack.com/download for
    linux
  - The previous releases were "beta" too, they just didn't mention
    it in the version string
@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: slack

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: slack

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit e386e19 into NixOS:master May 26, 2018
@benley benley deleted the benley/slack-3.2.0-beta2 branch May 26, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @GrahamcOfBorg @xeji