MBS-9675, MBS-9676: Fix work attributes localization issues in the release relationship editor #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in release relationship editor for adding a new work.
mwiencek
approved these changes
May 28, 2018
mwiencek
reviewed
May 28, 2018
| @@ -1,4 +1,4 @@ | |||
| [%- WRAPPER 'layout.tt' full_width=1 title=l('Edit Relationships: {release}', {release => release.name}) -%] | |||
| [%- WRAPPER 'layout.tt' full_width=1 title=l('Edit Relationships: {release}', {release => release.name}) gettext_domains=['attributes'] -%] | |||
There was a problem hiding this comment.
This seems odd though since the entity-creation dialog uses an iframe (so it should be sandboxed and have its own window and set of scripts that it loads?).
There was a problem hiding this comment.
Err, it actually doesn’t solve the issue at all. I don’t know how did it get to work for me, maybe I had some other local changes or was not working from the correct base branch.
I reverted it and proposed an actual fix in PR #675.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix both bugs MBS-9675 and MBS-9676
Cause was translation domain
attributeswas not loaded from the relationship editor, whereas it is required for adding new works when no existing work is found.