Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchFromGitlab: domain can be specified #41265

Merged
merged 1 commit into from May 30, 2018
Merged

fetchFromGitlab: domain can be specified #41265

merged 1 commit into from May 30, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 30, 2018 •
edited

Motivation for this change

Gitlab can be self hosted so you should be able to specify the domain.
It defaults to "gitlab.com" if none is specified.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

cc @matthewbauer

@matthewbauer matthewbauer merged commit 04bd841 into NixOS:master May 30, 2018
@worldofpeace worldofpeace deleted the fetchfromgitlab-domain branch May 31, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @matthewbauer @FRidh @GrahamcOfBorg