openshift: fix mkdir command #41274
Merged
openshift: fix mkdir command #41274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@GrahamcOfBorg build openshift |
xeji
reviewed
May 30, 2018
| @@ -48,7 +48,7 @@ in stdenv.mkDerivation rec { | |||
|
|
|||
| substituteInPlace pkg/oc/bootstrap/docker/host/host.go \ | |||
| --replace 'nsenter --mount=/rootfs/proc/1/ns/mnt mkdir' \ | |||
| 'nsenter --mount=/rootfs/proc/1/ns/mnt ${utillinux}/bin/mount' | |||
| 'nsenter --mount=/rootfs/proc/1/ns/mnt ${utillinux}/bin/mkdir' | |||
There was a problem hiding this comment.
Did you test this? mkdir is part of coreutils, not utillinux.
|
Success on x86_64-linux (full log) Attempted: openshift Partial log (click to expand)
|
|
@GrahamcOfBorg eval |
|
Success on aarch64-linux (full log) Attempted: openshift Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: openshift Partial log (click to expand)
|
|
@GrahamcOfBorg build openshift |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: openshift Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: openshift Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: openshift Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Wrong command replacement (mount -> mkdir)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)