Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly describe the effects of filterSource excluding a directory. #2197

Merged
merged 1 commit into from May 30, 2018
Merged

Explicitly describe the effects of filterSource excluding a directory. #2197

merged 1 commit into from May 30, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented May 30, 2018

No description provided.

grahamc
grahamc approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd love to see a backport too.

@mightybyte
Copy link
Contributor

Very helpful. It took me awhile to figure this out because at first glance I assumed it worked like a purely functional list filter where each element is analyzed independently.

@shlevy shlevy merged commit bbbfc18 into NixOS:master May 30, 2018
@shlevy shlevy deleted the filterSource-directory-exclusion branch May 30, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlevy @mightybyte @grahamc