Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul-ui: fix build #41268

Merged
merged 1 commit into from May 31, 2018
Merged

consul-ui: fix build #41268

merged 1 commit into from May 31, 2018

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented May 30, 2018

Motivation for this change

consul-ui is currently failing to build in 18.03 and master (#41238).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

My previous PR (#41239) was against the 18.03 branch because the fix did not work in master. This newer version works in both master and 18.03.

Update the dependencies used for building consul-ui. therubyracer is no longer required and fails to build. Instead, a nodejs binary is required to build the assets. Patch out unnecessary executions of bundle which can cause failures and also prevents need for patching the Gemfile.lock in the consul source, based on suggestion by @nh2.

Closes #41238

@jbboehr
consul-ui: fix build
711f96e 
Update the dependencies used for building consul-ui. therubyracer
is no longer required and fails to build. Instead, a nodejs
binary is required to build the assets. Patch out unnecessary
executions of `bundle` which can cause failures.
@jbboehr
Copy link
Contributor Author

jbboehr commented May 30, 2018

@7c6f434c Looks like there might be an issue with your latest commit: https://gist.github.com/GrahamcOfBorg/27d3550cdabe42098a41f92d433a4181

@7c6f434c
Copy link
Member

@GrahamcOfBorg eval

@7c6f434c
Copy link
Member

A direct reference stopped on meta.broken before going into loop, so I thought there is no need to double-check… Fixed, sorry

@7c6f434c
Copy link
Member

@GrahamcOfBorg build consul-ui

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: consul-ui

Partial log (click to expand)

  adding: static/apple-touch-icon-60x60.png (stored 0%)
  adding: static/apple-touch-icon-144x144.png (deflated 0%)
  adding: static/mstile-70x70.png (deflated 0%)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2d6l2936cr0xddv8y9lgy175dksgwb2v-consul-ui-0.9.3
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2d6l2936cr0xddv8y9lgy175dksgwb2v-consul-ui-0.9.3
checking for references to /build in /nix/store/2d6l2936cr0xddv8y9lgy175dksgwb2v-consul-ui-0.9.3...
/nix/store/2d6l2936cr0xddv8y9lgy175dksgwb2v-consul-ui-0.9.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: consul-ui

Partial log (click to expand)

  adding: static/mstile-150x150.png (deflated 0%)
  adding: static/mstile-310x150.png (deflated 0%)
  adding: static/mstile-310x310.png (deflated 0%)
  adding: static/mstile-70x70.png (deflated 0%)
  adding: static/safari-pinned-tab.svg (deflated 52%)
installing
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/5xhldkd5862y83s8miv3f71z24b0lsfg-consul-ui-0.9.3
/nix/store/5xhldkd5862y83s8miv3f71z24b0lsfg-consul-ui-0.9.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: consul-ui

Partial log (click to expand)

  adding: static/android-chrome-192x192.png (deflated 1%)
  adding: static/base.css (deflated 89%)
  adding: static/application.min.js (deflated 76%)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2jkljz1idj7vs7irwhl9c51a5gn8bp15-consul-ui-0.9.3
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2jkljz1idj7vs7irwhl9c51a5gn8bp15-consul-ui-0.9.3
checking for references to /build in /nix/store/2jkljz1idj7vs7irwhl9c51a5gn8bp15-consul-ui-0.9.3...
/nix/store/2jkljz1idj7vs7irwhl9c51a5gn8bp15-consul-ui-0.9.3

@7c6f434c 7c6f434c merged commit 5737e1f into NixOS:master May 31, 2018
@xeji xeji mentioned this pull request May 31, 2018
Closed
8 tasks
@jbboehr jbboehr mentioned this pull request Aug 28, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consul-ui fails to build
3 participants
@jbboehr @7c6f434c @GrahamcOfBorg