[RFC/RDY] flent: add manpage + init http-getter #41614

teto · 2018-06-07T04:55:06Z

Motivation for this change

without at least netperf the program is useless since it is an interface to netperf.
http-getter is a small utility used just by flent so I addded it to the flent default.nix.

NB: for those testing it, I kept the stable release but there is a nasty bug that was solved there
tohojo/flent#137 so you might need to override the src to sthg more recent.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-06-07T05:08:30Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flent

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-07T05:08:45Z

Success on x86_64-linux (full log)

Attempted: flent

Partial log (click to expand)

test_create_timeseries (unittests.test_plotters.TestPlotters) ... ok
test_create_timeseries_combine (unittests.test_plotters.TestPlotters) ... ok
test_load_tests (unittests.test_tests.TestTests) ... ok

----------------------------------------------------------------------
Ran 26 tests in 4.563s

OK
postPatchMkspecs
/nix/store/5z6i0bd4r248jahlhl9fmbl9b19m6c9d-flent-1.2.2

GrahamcOfBorg · 2018-06-08T08:14:22Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flent

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-08T10:09:04Z

Failure on x86_64-linux (full log)

Attempted: flent

Partial log (click to expand)

checking for references to /build in /nix/store/y1071aid72sabrhllhdgrallsixw8ncx-qtwebkit-5.9.1-dev...
postPatchMkspecs
fixQtModulePaths: Fixing module paths in `/nix/store/y1071aid72sabrhllhdgrallsixw8ncx-qtwebkit-5.9.1-dev/mkspecs/modules/qt_lib_webkitwidgets.pri'...
fixQtModulePaths: Fixing module paths in `/nix/store/y1071aid72sabrhllhdgrallsixw8ncx-qtwebkit-5.9.1-dev/mkspecs/modules/qt_lib_webkitwidgets_private.pri'...
fixQtModulePaths: Fixing module paths in `/nix/store/y1071aid72sabrhllhdgrallsixw8ncx-qtwebkit-5.9.1-dev/mkspecs/modules/qt_lib_webkit.pri'...
fixQtModulePaths: Fixing module paths in `/nix/store/y1071aid72sabrhllhdgrallsixw8ncx-qtwebkit-5.9.1-dev/mkspecs/modules/qt_lib_webkit_private.pri'...
postPatchMkspecs
cannot build derivation '/nix/store/4yfavrkhw7q1g4qf2sznm17kzpps0jja-python3.6-PyQt-5.10.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lrvl9x8rp803rwd51bi96n4jdk38nzcc-flent-1.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lrvl9x8rp803rwd51bi96n4jdk38nzcc-flent-1.2.2.drv' failed

xeji · 2018-06-10T21:21:55Z

pkgs/applications/networking/flent/default.nix

-{ stdenv, buildPythonApplication, fetchFromGitHub, matplotlib, netperf, procps, pyqt5 }:
+{ stdenv, buildPythonApplication, fetchFromGitHub, matplotlib, netperf, procps, pyqt5
+, makeWrapper, iperf2
+, withMan ? true, sphinx ? null


I don't think it's worth making the manual optional. Doesn't take long to build (and hydra does it for you anyway), and it's put in a separate output. So I suggest to remove this option and always build the manual, which is the de-facto standard in nixpkgs.

I received different feedback on other PRs but I definitely agree we should encourage manpages so I build it by default.

xeji · 2018-06-10T21:26:47Z

pkgs/applications/networking/flent/default.nix

  propagatedBuildInputs = [
    matplotlib
    procps
    pyqt5
  ];

+  postBuild = stdenv.lib.optionalString withMan ''
+    make man


This postBuild is not necessary and can be removed. The manual is built automatically.

teto · 2018-06-13T14:32:49Z

In the end I removed the wrapping since it might pull too much otherwise and wouldn't work in python development mode which was my interest. The PR juste enables the manpage and add http-getter to cover some tests in flent.

So people should keep using it describing the necessary dependencies nix-shell -p flent iperf http-getter etc

GrahamcOfBorg · 2018-06-13T14:52:33Z

Success on x86_64-linux (full log)

Attempted: flent, http-getter

Partial log (click to expand)

test_create_timeseries_combine (unittests.test_plotters.TestPlotters) ... ok
test_load_tests (unittests.test_tests.TestTests) ... ok

----------------------------------------------------------------------
Ran 26 tests in 4.700s

OK
postPatchMkspecs
/nix/store/sa3zqh70l8g6ija2dqb1ki26vyp6q0aq-flent-1.2.2
/nix/store/53kfkpf2b2mfhcm9xshyd97a6ix3mf2v-http-getter

GrahamcOfBorg · 2018-06-13T15:51:58Z

Failure on aarch64-linux (full log)

Attempted: flent, http-getter

Partial log (click to expand)

[4565/17529] CXX obj/third_party/icu/bundled_icui18n/precision.o
[4566/17529] CXX obj/third_party/WebKit/Source/platform/wtf/wtf/BitVector.o
[4567/17529] CXX obj/third_party/icu/bundled_icui18n/nfsubs.o
[4568/17529] CXX obj/third_party/icu/bundled_icui18n/quant.o
[4569/17529] CXX obj/third_party/icu/bundled_icui18n/regexst.o
[4570/17529] CXX obj/third_party/icu/bundled_icui18n/region.o
building of '/nix/store/lssdkibmydaff326bfilmdkgzmhbdz7k-qtwebengine-5.10.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/cdkfra7xdjkzw6gnvhyj8jbsxsv7m2ib-python3.6-PyQt-5.10.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ijhxi08w5pq520wi5v0lshlpi32ww625-flent-1.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ijhxi08w5pq520wi5v0lshlpi32ww625-flent-1.2.2.drv' failed

Used by flent

mmlb · 2019-08-08T03:43:05Z

In the end I removed the wrapping since it might pull too much otherwise and wouldn't work in python development mode which was my interest.

hey @teto what did you mean by python-development mode, do you recall? Maybe we should do 2 packages here, flent and flent-full or something? I'd like to have all the needed tools depended on and brought in somehow.

teto · 2019-08-08T04:34:01Z

@mmlb I meant I was using flent in a nix-shell (equivalent to python setup.py develop). So the executable is not wrapped (maybe there is some trick to wrap it).
I think we should add an extraLibs settings like in i3pystatus

nixpkgs/pkgs/applications/window-managers/i3/pystatus.nix

Line 1 in 47b551c

{ stdenv, fetchFromGitHub, libpulseaudio, python3Packages, extraLibs ? [] }:

, default it to a full setting that people can override.

teto mentioned this pull request Jun 7, 2018

Wrap some utilities in flent ? #41521

Closed

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 7, 2018

xeji reviewed Jun 10, 2018

View reviewed changes

teto force-pushed the flent_wrap branch from 9c6dda7 to 0080fe9 Compare June 13, 2018 14:29

teto changed the title ~~flent: wrap binaries with netperf/iperf/http-getter~~ [RFC] flent: wrap binaries with netperf/iperf/http-getter Jun 13, 2018

GrahamcOfBorg added the 8.has: package (new) label Jun 13, 2018

teto added 2 commits June 14, 2018 08:27

flent: enable man by default

e96ce01

http-getter: init at 20180606

0080fe9

Used by flent

teto changed the title ~~[RFC] flent: wrap binaries with netperf/iperf/http-getter~~ [RFC/RDY] flent: wrap binaries with netperf/iperf/http-getter Jun 15, 2018

teto changed the title ~~[RFC/RDY] flent: wrap binaries with netperf/iperf/http-getter~~ [RFC/RDY] flent: add manpage + init http-getter Jun 17, 2018

matthewbauer merged commit 9185df5 into NixOS:master Jun 22, 2018

teto deleted the flent_wrap branch June 22, 2018 02:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC/RDY] flent: add manpage + init http-getter #41614

[RFC/RDY] flent: add manpage + init http-getter #41614

teto commented Jun 7, 2018 •

edited

GrahamcOfBorg commented Jun 7, 2018

GrahamcOfBorg commented Jun 7, 2018

GrahamcOfBorg commented Jun 8, 2018

GrahamcOfBorg commented Jun 8, 2018

xeji Jun 10, 2018

teto Jun 13, 2018

xeji Jun 10, 2018

teto commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

mmlb commented Aug 8, 2019 •

edited

teto commented Aug 8, 2019

[RFC/RDY] flent: add manpage + init http-getter #41614

[RFC/RDY] flent: add manpage + init http-getter #41614

Conversation

teto commented Jun 7, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Jun 7, 2018

GrahamcOfBorg commented Jun 7, 2018

GrahamcOfBorg commented Jun 8, 2018

GrahamcOfBorg commented Jun 8, 2018

xeji Jun 10, 2018

Choose a reason for hiding this comment

teto Jun 13, 2018

Choose a reason for hiding this comment

xeji Jun 10, 2018

Choose a reason for hiding this comment

teto commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

mmlb commented Aug 8, 2019 • edited

teto commented Aug 8, 2019

teto commented Jun 7, 2018 •

edited

mmlb commented Aug 8, 2019 •

edited