Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/qemu: tell qemu where to find smbd #41615

Merged
merged 1 commit into from Jun 10, 2018
Merged

pkgs/qemu: tell qemu where to find smbd #41615

merged 1 commit into from Jun 10, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Jun 7, 2018

Motivation for this change

QEMU is able to start a Samba server to facilitate sharing files between the guest and host, but it needs to be told where the smbd binary is at compile time.

Before this change, QEMU threw an error if run with -net user,smb=/path/to/shared/folder even if smbd was in $PATH:

qemu-system-x86_64: Could not find 'smbd', please install it

Despite the comment on this line, it doesn't appear to have worked:

nixpkgs/pkgs/applications/virtualization/qemu/default.nix

Line 103 in f5b0d6d

[ "--smbd=smbd" # use `smbd' from $PATH

This change fixes that if built with smbdSupport = true.

Things done

Note that I didn't test all the binaries because there's a lot of them, but I did test qemu-system-x86_64.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

@GrahamcOfBorg build qemu_kvm

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qemu_kvm

Partial log (click to expand)

find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
find: '/nix/store/ijrlrd8jrls2a8s0dikwvs1yqkb900r6-qemu-host-cpu-only-2.12.0-ga': No such file or directory
/nix/store/gywyj53ikrdmqim1xjn9aasy8sir9hsy-qemu-host-cpu-only-2.12.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qemu_kvm

Partial log (click to expand)

patching script interpreter paths in /nix/store/z7f7xr2ivhw94maiyb5rdjdv92lzr2js-qemu-host-cpu-only-2.12.0
checking for references to /build in /nix/store/z7f7xr2ivhw94maiyb5rdjdv92lzr2js-qemu-host-cpu-only-2.12.0...
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
/nix/store/z7f7xr2ivhw94maiyb5rdjdv92lzr2js-qemu-host-cpu-only-2.12.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qemu_kvm

Partial log (click to expand)

patching script interpreter paths in /nix/store/vmcjql7ghnnpsj1p31b8hy66fvlds22c-qemu-host-cpu-only-2.12.0
checking for references to /build in /nix/store/vmcjql7ghnnpsj1p31b8hy66fvlds22c-qemu-host-cpu-only-2.12.0...
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
/nix/store/vmcjql7ghnnpsj1p31b8hy66fvlds22c-qemu-host-cpu-only-2.12.0

@xeji xeji merged commit 0b3f13d into NixOS:master Jun 10, 2018
@eqyiel eqyiel deleted the qemu-smbd branch November 3, 2020 12:59
@nh2 nh2 mentioned this pull request Feb 23, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eqyiel @xeji @GrahamcOfBorg