Adds filename to sha256 file for use with sha256 -c
#17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manpage says:
By adding the filename to the generated sha256 file, a user would be
able to download an iso, the sha256 file, then use
sha256 -c [file].iso.sha256
to verify the file.This fixes nixos-homepage#224
Additional notes
Breaking assumptions
This could break assumptions where the
.sha256
files were previously used as they were. I have briefly looked and couldn't find evidence of such use.Testing
I couldn't test the entire changes in-place, but here's how I tested them:
Using this test.pl file,
So at least, the basic code is expected to work.
Am I right in assuming there is no test suite for the mirroring script?