Zig Fmt recursive option #1068
Zig Fmt recursive option #1068
Conversation
src-self-hosted/main.zig
Outdated
| return blk: { | ||
| const source_code = io.readFileAlloc(allocator, file_path) catch |err| { | ||
| try stderr.print("unable to open '{}': {}\n", file_path, err); | ||
| break :blk false; |
There was a problem hiding this comment.
You can just use a straight return for these. No need to pass return via the :blk.
There was a problem hiding this comment.
Ooops, should have realised this
|
@andrewrk the the failed travis check don't seem at all related to my PR maybe another issue from another PR? And the other one is because windows directories isn't implemented yet in the std ( How would you advise we approach this? I think this PR should stay open till windows support for Directories is supported in std, then it can be merged; rather than conflating windows directory support with this PR? |
|
This PR cannot be merged until #709 is done |
|
When #1071 is pushed this can be merged in, I'll close and reopen it before then so the checks will re-run :). |
|
Recursive directory traversal is a dangerous road to go down. There are lots of features you can support in this domain that people will ask for. Traversing directories is a harder problem than it seems, and I think we should leave it outside the scope of zig fmt. You can always use |
|
@thejoshwolfe Almost every 'fmt'er out there supports atleast this basic recursion, for example go fmt supports this exact type of fmt I'm showing here (very simple recursive search). And for the 'scope' of this, it really isn't that much larger; its performing an extremely simple recursive search on directories for the exact reason you gave, its a lot harder of a problem then it seems and it is easier to begin with a simple solution. I don't think using find and -exec is a solution, that seems hackish and annoying to me personally :). A list of formatters that have this feature that I've commonly used before and from asking a few people I know all said that they commonly use;
|
|
This implementation selects files that end with |
|
Everything should be okay now :).
|
|
I'll look at this tomorrow morning. |
|
I haven't forgotten this - I'm part way through merging it, should have it merged tomorrow at some point. |
As the title says, you can call it like
zig fmt src/ otherFile.zig otherStuff/inside/ -r, if you forget the -r it'll give you an errorTo fmt recursively pass the '-r' flag., this is to prevent people accidentally doing recursive and causing unexpected damage for whatever reason :).Added this since I wanted to run it on a source directory of my Lazy Zig library and it was annoying to have to give 10+ source files rather than just saying
zig fmt -r src/NOTE: doesn't work on windows, since windows doesn't have directory code yet. I'll have a look in another PR if I have time to see if I can implement it.