Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openspace: init at 0.11.1 #42149

Merged
merged 1 commit into from Jul 23, 2018
Merged

openspace: init at 0.11.1 #42149

merged 1 commit into from Jul 23, 2018

Conversation

timjrd
Copy link
Contributor

@timjrd timjrd commented Jun 18, 2018 •
edited

Hi :)

Motivation for this change

This adds a new package: OpenSpace, an open source astrovisualization project, and one of its dependencies: SOIL (Simple OpenGL Image Library).

This kind of works for me, but please note that this build is not very usable for now. This is a first attempt. Also, Linux doesn't seem to be well supported upstream, hence the various patches (I will open an issue upstream to discuss them).

This PR was successfully built against release-18.03 and nixos-unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • (except for meta.maintainers) Fits CONTRIBUTING.md.

pSub
pSub reviewed Jun 18, 2018
View reviewed changes
pkgs/applications/science/astronomy/openspace/default.nix Outdated
libX11 libXi libXxf86vm libXcursor libXrandr libXinerama
];

patches = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchpatch for all patches available upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only patch available upstream is glm.patch. I could fetch the corresponding commit patch from glm's github repo, but glm is a submodule of openspace, so I can't apply the patch to the openspace source tree. Also, I made this patch by picking a whole file from a specific commit and replacing the several matching files in the source tree, which might not lead to the same result as applying the commit patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I could fetch this file from github with fetchurl, and manually replace the matching files in the source tree ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchpatch takes an optional argument extraPrefix. Are you sure this is not good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip, I will try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with fetchurl. I tried the fetchpatch method but it did not succeed because the commit patch was not applicable (the version of the file before the commit and the version of the source tree one did not match).

@timjrd
openspace: init at 0.11.1
cb597c2 
This adds a new package: OpenSpace, an open source astrovisualization
project, and one of its dependencies: SOIL (Simple OpenGL Image
Library).

This kind of works for me, but please note that this build is not very
usable for now. This is a first attempt. Also, Linux doesn't seem to
be well supported upstream, hence the various patches (I will open an
issue upstream to discuss them).

Squashed commits:
openspace: fetch upstream glm "patch"
openspace: add missing dependency (libXxf86vm)
soil: mesa -> mesa_noglu
@timjrd timjrd mentioned this pull request Jun 22, 2018
Closed
@matthewbauer
Copy link
Member

@GrahamcOfBorg build openspace

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openspace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openspace

Partial log (click to expand)

shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/bin/Sync
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/bin/OpenSpace
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/bin/OpenSpaceTest
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/lib/libSpice.so
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/lib/libLua.so
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/bin
patching script interpreter paths in /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1
checking for references to /build in /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1...
/nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1

@matthewbauer matthewbauer merged commit 6d880d2 into NixOS:master Jul 23, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: openspace

Partial log (click to expand)

In file included from /build/hdf-4.2.14/hdf/src/hdf.h:155:0,
                 from /build/hdf-4.2.14/hdf/src/dfp.c:32:
/build/hdf-4.2.14/hdf/src/hdatainfo.h:29:5: error: unknown type name 'uint16'
     uint16 tag;
     ^~~~~~
/build/hdf-4.2.14/hdf/src/hproto.h:1957:18: error: unknown type name 'int32'; did you mean 'int'?
building of '/nix/store/ylhwahgicq098qg61lf0sncgsr59f32q-hdf-4.2.14.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/x9sd7zdk62b7kc04y4j98xfcgvy4qy49-gdal-2.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bkz7k7z7p7lsiygpnqw2cgiqvqr13128-openspace-0.11.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bkz7k7z7p7lsiygpnqw2cgiqvqr13128-openspace-0.11.1.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

@pSub pSub pSub left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timjrd @matthewbauer @GrahamcOfBorg @adisbladis @pSub @Janik-Haag