nifskope: 1.1.3 -> 2.0.dev7 #42143
Merged
nifskope: 1.1.3 -> 2.0.dev7 #42143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nifskope` v2 contains a lot of new features and a new, QT5-based UI (see https://github.com/niftools/nifskope/releases). Additionally the 2.0 sourcetree exists for quite a while and after some short user tests it seems fairly stable. The following aspects have been changed: * Use QT 5.9 rather than QT4 (see NixOS#33248). * GCC7 support from upstream (gcc6 patch not needed anymore, build on GCC7 works fine), disabled `-Werror=format-security` can be used again as compiler flag. * Patched broken paths in `NifSkope_targets.pri` to point to the proper dependencies (otherwise `<gli.hpp>` and `qhull` couldn't be found). * Patched paths in `NifSkope.pro` to `lupdate` and `lrelease` (default `QT_*` paths point to `libsForQt5x.qtbase` which doesn't contain the needed binaries, instead they need to point to `libsForQt5x.qttools`). * Added myself as maintainer.
|
Failure on aarch64-linux (full log) Attempted: nifskope Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: nifskope Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
nifskopev2 contains a lot of new features and a new, QT5-based UI(see https://github.com/niftools/nifskope/releases). Additionally the
2.0 sourcetree exists for quite a while and after some short user tests
it seems fairly stable.
The following aspects have been changed:
Use QT 5.9 rather than QT4 (see Qt4 deprecation tracking issue #33248).
GCC7 support from upstream (gcc6 patch not needed anymore, build on
GCC7 works fine), disabled
-Werror=format-securitycan be used againas compiler flag.
Patched broken paths in
NifSkope_targets.prito point to the properdependencies (otherwise
<gli.hpp>andqhullcouldn't be found).Patched paths in
NifSkope.protolupdateandlrelease(defaultQT_*paths point tolibsForQt5x.qtbasewhich doesn't contain theneeded binaries, instead they need to point to
libsForQt5x.qttools).Added myself as maintainer.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)