Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/modules: decrease mkOptionDefault priority to 1500 #42138

Merged
merged 1 commit into from Jun 27, 2018
Merged

lib/modules: decrease mkOptionDefault priority to 1500 #42138

merged 1 commit into from Jun 27, 2018

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Jun 17, 2018 •
edited

That allows to create defaults between mkDefault and mkOptionDefault. That would be very useful for nixos-hardware repo where ideally we should use level of priority lower than mkDefault, so that mkDefault works if set by user.

@xeji
Copy link
Contributor

xeji commented Jun 18, 2018

LGTM. Should be pretty safe since priorities between 1002 and 1500 are currently not used in NixOS.
In theory there's a small risk of breaking existing configs that use such a priority for whatever reason. But I believe that's rather unlikely (why would anyone do that?).

@xeji xeji merged commit 249be1c into master Jun 27, 2018
@lukateras lukateras deleted the yegortimoshenko-patch-6 branch October 5, 2018 01:00
@Anton-Latukha Anton-Latukha mentioned this pull request Sep 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @xeji @GrahamcOfBorg