Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pencil : fix udev dependency #42147

Merged
merged 1 commit into from Jun 18, 2018
Merged

pencil : fix udev dependency #42147

merged 1 commit into from Jun 18, 2018

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

because of changes in the udev package the package was not working anymore

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Jun 18, 2018
View reviewed changes
pkgs/applications/graphics/pencil/default.nix Outdated
@@ -89,7 +89,7 @@ stdenv.mkDerivation rec {
chmod a+x $out/opt/Pencil/libffmpeg.so

# fix missing libudev
ln -s ${udev}/lib/systemd/libsystemd-shared.so $out/opt/Pencil/libudev.so.1
ln -s ${eudev}/lib/libudev.so.1 $out/opt/Pencil/libudev.so.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would ln -s ${systemd.lib}/lib/libudev.so.1 $out/opt/Pencil/libudev.so.1 also work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, is it better ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eudev is the gentoo-maintained udev fork while systemd is the canonical udev upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adisbladis Ah this explains why I thought it is the proper one :D (I used gentoo for a very long time in my life)

@Mic92 Yes it works, in a few minutes I'll push the changes.

@xeji
Copy link
Contributor

xeji commented Jun 18, 2018

@GrahamcOfBorg build pencil

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pencil

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pencil

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4
shrinking /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4/opt/Pencil/libffmpeg.so
shrinking /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4/opt/Pencil/.pencil-wrapped
shrinking /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4/opt/Pencil/libnode.so
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4/bin
patching script interpreter paths in /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4
head: error writing 'standard output': Broken pipe
checking for references to /build in /nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4...
/nix/store/3mrq5dw3ni7i60dwjipg6mkas76g0hjf-pencil-3.0.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pencil

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4
shrinking /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4/opt/Pencil/.pencil-wrapped
shrinking /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4/opt/Pencil/libffmpeg.so
shrinking /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4/opt/Pencil/libnode.so
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4/bin
patching script interpreter paths in /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4
head: error writing 'standard output': Broken pipe
checking for references to /build in /nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4...
/nix/store/8yiis8j5ns9b85wsv77cd2zy99kjpgzw-pencil-3.0.4

@xeji xeji merged commit 29d8149 into NixOS:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrVanDalo @xeji @GrahamcOfBorg @adisbladis @Mic92