Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ical2org: init at v.1.1.5 #42141

Merged
merged 2 commits into from Jun 18, 2018
Merged

ical2org: init at v.1.1.5 #42141

merged 2 commits into from Jun 18, 2018

Conversation

swflint
Copy link
Contributor

@swflint swflint commented Jun 17, 2018 •
edited

Motivation for this change

ical2org is a package that allows users to pull ical files and convert them to org-mode format for use with the org-mode agenda.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

LnL7
LnL7 reviewed Jun 17, 2018
View reviewed changes
pkgs/tools/misc/ical2org/default.nix Outdated
license = licenses.gpl3;
maintainers = with maintainers; [ swflint ];
platforms = platforms.unix;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a semicolon here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@adisbladis
Copy link
Member

@GrahamcOfBorg build ical2org

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ical2org

Partial log (click to expand)

shrinking /nix/store/86371k91vnil9xldagywyqsl04xxbg60-ical2org-v.1.1.5-bin/bin/ical2org
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/86371k91vnil9xldagywyqsl04xxbg60-ical2org-v.1.1.5-bin/bin
patching script interpreter paths in /nix/store/86371k91vnil9xldagywyqsl04xxbg60-ical2org-v.1.1.5-bin
checking for references to /build in /nix/store/86371k91vnil9xldagywyqsl04xxbg60-ical2org-v.1.1.5-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/kkq2nh5mv7q1xrmi2vs5pz4v2qpbj4f1-ical2org-v.1.1.5
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/kkq2nh5mv7q1xrmi2vs5pz4v2qpbj4f1-ical2org-v.1.1.5
checking for references to /build in /nix/store/kkq2nh5mv7q1xrmi2vs5pz4v2qpbj4f1-ical2org-v.1.1.5...
/nix/store/86371k91vnil9xldagywyqsl04xxbg60-ical2org-v.1.1.5-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ical2org

Partial log (click to expand)

installing
/private/tmp/nix-build-ical2org-v.1.1.5.drv-0/go /private/tmp/nix-build-ical2org-v.1.1.5.drv-0
/private/tmp/nix-build-ical2org-v.1.1.5.drv-0
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1x2rgwl123vx4m9s5z3vgly9xldp4y4i-ical2org-v.1.1.5-bin/bin
patching script interpreter paths in /nix/store/1x2rgwl123vx4m9s5z3vgly9xldp4y4i-ical2org-v.1.1.5-bin
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/bp62r023nqnqqkp7grrf0a4gw1sr9xm8-ical2org-v.1.1.5
/nix/store/1x2rgwl123vx4m9s5z3vgly9xldp4y4i-ical2org-v.1.1.5-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ical2org

Partial log (click to expand)

shrinking /nix/store/8grfi2kr4cppk1q2xv4218kvmn3j2m10-ical2org-v.1.1.5-bin/bin/ical2org
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8grfi2kr4cppk1q2xv4218kvmn3j2m10-ical2org-v.1.1.5-bin/bin
patching script interpreter paths in /nix/store/8grfi2kr4cppk1q2xv4218kvmn3j2m10-ical2org-v.1.1.5-bin
checking for references to /build in /nix/store/8grfi2kr4cppk1q2xv4218kvmn3j2m10-ical2org-v.1.1.5-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/ll7hm3j4yjv9wij2zpmagfg7889wr1ys-ical2org-v.1.1.5
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ll7hm3j4yjv9wij2zpmagfg7889wr1ys-ical2org-v.1.1.5
checking for references to /build in /nix/store/ll7hm3j4yjv9wij2zpmagfg7889wr1ys-ical2org-v.1.1.5...
/nix/store/8grfi2kr4cppk1q2xv4218kvmn3j2m10-ical2org-v.1.1.5-bin

@adisbladis
Copy link
Member

This looks super useful. Thanks!

@adisbladis adisbladis merged commit d201872 into NixOS:master Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@swflint @adisbladis @GrahamcOfBorg @LnL7