Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve build failed syncserver #41358

Closed
wants to merge 1 commit into from
Closed

resolve build failed syncserver #41358

wants to merge 1 commit into from

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Jun 1, 2018

Motivation for this change

I would like to repair syncserver on Nixos. Because the mozsvc and server-syncstorage use two incompatibles versions of the same python library, some tests at the installation didn't pass. So I disabled them meanwhile I try to suggest technical changes in mozsvc application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Vskilet Vskilet requested a review from FRidh as a code owner June 1, 2018 13:18
@Vskilet Vskilet mentioned this pull request Jun 1, 2018
Closed
@FRidh
Copy link
Member

FRidh commented Jun 2, 2018

Because the mozsvc and server-syncstorage use two incompatibles versions of the same python library, some tests at the installation didn't pass.

But does it work, despite the failing tests?

So I disabled them meanwhile I try to suggest technical changes in mozsvc application.

I suggest doing this in a single PR with commits for each of the components.

@Vskilet
Copy link
Contributor Author

Vskilet commented Jun 2, 2018 •
edited

But does it work, despite the failing tests?

I can build it but maybe someone should test in a test environment. It works for docker container in fact.

I suggest doing this in a single PR with commits for each of the components.

Ok

@FRidh
Copy link
Member

FRidh commented Jun 23, 2018

Closing as this change is not sufficient.

@FRidh FRidh closed this Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vskilet @FRidh @GrahamcOfBorg @Janik-Haag