dockerTools.pullImage: expose image* attributes #41366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes `imageName` and `imageTag` are exposed if the image is built by our Nix tools but not if the image is pulled. So, we expose these attributes for convenience and homogeneity.
orivej
added a commit
that referenced
this pull request
Jun 4, 2018
* master: (26 commits) python.pkgs.cairocffi: update tests for Cairo 1.15.12 python.pkgs.cairocffi: 0.8.0 -> 0.8.1 freecell-solver: fix build perlPackages.CPANPLUS: restore build inputs removed in #41394 Fix GHCJS 8.4/8.2 in sandboxed builds (#41411) dockerTools.pullImage: expose image* attributes (#41366) rust: disable tests on darwin python.pkgs.detox: 0.11 -> 0.12 certbot: disable check on darwin freeimage: fix build with glibc 2.27 shadowsocks-libev: supports darwin (#41421) pythonPackages.jira: fix build (#41419) SDL: propagate libiconv schema2ldif: Init at 1.3 nixos/exim: Add unit restart trigger (#41418) Add myself as maintainer for dnsdist Add myself as maintainer synapse-bt: init at 2018-06-04 (#41402) skim: 0.3.2 -> 0.4.0 (#41417) ctags: fix source url (#41382) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes
imageNameandimageTagare exposed if the image isbuilt by our Nix tools but not if the image is pulled. So, we expose
these attributes for convenience and homogeneity.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)