Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mpd: allow services.mpd.dbFile to be null #41367

Merged
merged 1 commit into from
Jun 1, 2018
Merged

nixos/mpd: allow services.mpd.dbFile to be null #41367

merged 1 commit into from
Jun 1, 2018
+6 −3

Conversation

andir
Copy link
Member

@andir andir commented Jun 1, 2018 •
edited
Loading

Motivation for this change

This change allows users to specify an alternative database method. For
example an mpd satellite setup where another mpd on the network shares
it's database with the local instance. The dbFile parameter must not be
configured in that case.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@andir
nixos/mpd: allow services.mpd.dbFile to be null

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
GPG key ID: E432E410B5E48C86
Expired
Verified
Learn about vigilant mode
a0797ba 
This change allows users to specify an alternative database method. For
example an mpd satellite setup where another mpd on the network shares
it's database with the local instance. The `dbFile` parameter must not be
configured in that case.
@andir andir force-pushed the nixos-mpd-dbFile-null branch from 35ae14c to a0797ba Compare June 1, 2018 17:17
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 1, 2018
@mweinelt
Copy link
Member

mweinelt commented Jun 1, 2018

I successfully tested that change on 18.03 with an mpd satellite setup.

@andir andir merged commit bc06962 into NixOS:master Jun 1, 2018
@andir andir deleted the nixos-mpd-dbFile-null branch June 1, 2018 17:40
@jfrankenau jfrankenau mentioned this pull request Jul 21, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @mweinelt @GrahamcOfBorg