Review ietf cellar ffv1 02 secdir early xia 2018 06 01 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retokromer
reviewed
Jun 1, 2018
| @@ -476,7 +474,7 @@ RFC:``` | |||
| RFC:j_{0} = 2 | |||
| RFC:``` | |||
|
|
|||
| #### Range non binary values | |||
| #### Range Non Binary Values | |||
There was a problem hiding this comment.
I am not an English speaker: Non Binary or Non-Binary?
There was a problem hiding this comment.
IIRC hyphens present in section headers break the inter-sectional linking as the document is processed through mmark and xml2rfc.
There was a problem hiding this comment.
Thank you for the explanation, @dericed!
retokromer
approved these changes
Jun 1, 2018
dericed
deleted the
review-ietf-cellar-ffv1-02-secdir-early-xia-2018-06-01
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses many of the comments in https://datatracker.ietf.org/doc/review-ietf-cellar-ffv1-02-secdir-early-xia-2018-06-01/.
#115 should be resolved before this is merged.