Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-wrapper.sh: Add --export flag #41369

Closed
wants to merge 1 commit into from

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Jun 1, 2018

Motivation for this change

Adds an --export flag to make-wrapper.sh to export previously unexported variables. This is important because the wrapped program is called using exec, so any unexported variables will not be visible to the wrapped program.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm having trouble testing this locally because it triggers a TON of rebuilds.

@xeji
Copy link
Contributor

xeji commented Jun 2, 2018

👎 from me. I don't think this new flag is useful in enough cases to justify its addition.
You can achieve the same effect by --run "export VAR" , see #41371 (comment).

@orivej orivej closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants