Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-audit: init at 0.1 #41370

Merged
merged 1 commit into from Jun 2, 2018
Merged

pass-audit: init at 0.1 #41370

merged 1 commit into from Jun 2, 2018

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Jun 1, 2018 •
edited

Motivation for this change

Adds the pass-audit extension for pass password manager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jbaum98 jbaum98 requested a review from Ericson2314 as a code owner June 1, 2018 18:12
@xeji
Copy link
Contributor

xeji commented Jun 1, 2018

please remove the make-wrapper.sh commit here as it is redundant to your other PR #41369.
Instead, note here that this PR depends on #41369.

@xeji
Copy link
Contributor

xeji commented Jun 1, 2018

your rebase seems to have gone wrong, see the extra commits that don't belong here

@xeji
Copy link
Contributor

xeji commented Jun 2, 2018

@GrahamcOfBorg build passExtensions.pass-audit

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: passExtensions.pass-audit

Partial log (click to expand)

pass-audit is installed succesfully

post-installation fixup
gzipping man pages under /nix/store/cja68sm0blisl8sdbgdvbx3bs1hzvajj-pass-audit-0.1/share/man/
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/cja68sm0blisl8sdbgdvbx3bs1hzvajj-pass-audit-0.1/lib
patching script interpreter paths in /nix/store/cja68sm0blisl8sdbgdvbx3bs1hzvajj-pass-audit-0.1
/nix/store/cja68sm0blisl8sdbgdvbx3bs1hzvajj-pass-audit-0.1/lib/password-store/audit/audit.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/zs1nwq46cxjbj1wyhgvh4f2f1bkb53h5-python3-3.6.5-env/bin/python3"
/nix/store/cja68sm0blisl8sdbgdvbx3bs1hzvajj-pass-audit-0.1/lib/password-store/extensions/audit.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/bash"
/nix/store/cja68sm0blisl8sdbgdvbx3bs1hzvajj-pass-audit-0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: passExtensions.pass-audit

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1
gzipping man pages under /nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1/share/man/
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1/lib
patching script interpreter paths in /nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1
/nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1/lib/password-store/extensions/audit.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/bash"
/nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1/lib/password-store/audit/audit.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/lmp2mwqi3z40qhd6nypsg80q978702p3-python3-3.6.5-env/bin/python3"
checking for references to /build in /nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1...
/nix/store/fff9rc6qdkpg52cfi7x8538888iqqmsj-pass-audit-0.1

@xeji xeji merged commit e7eac1b into NixOS:master Jun 2, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: passExtensions.pass-audit

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1
gzipping man pages under /nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1/lib
patching script interpreter paths in /nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1
/nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1/lib/password-store/audit/audit.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/1w2223yyj514dipdbfj07mw15yiar9bx-python3-3.6.5-env/bin/python3"
/nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1/lib/password-store/extensions/audit.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1...
/nix/store/h8birc2axij868daa1ns9y0j1psl6lf1-pass-audit-0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbaum98 @xeji @GrahamcOfBorg