MBS-9736: Convert the artist search results page to React #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanzo
requested changes
Jun 6, 2018
There was a problem hiding this comment.
IMHO, commits should make easy to track code/feature moving from Perl/TT to React/JSX. I would personally make only one commit for both removing the old TT template and adding the new JSX component. If that cannot be done within the same commit, I would add references in both commit messages.
| ) : ( | ||
| <p>{l('No results found. Try refining your search query.')}</p> | ||
| )} | ||
| {$c.user && $c.user.is_location_editor ? ( |
There was a problem hiding this comment.
is_editing_enabled should be checked in place of is_location_editor.
!$c.user.is_editing_disabled should be checked in place of $c.user.is_location_editor.
$Subtype is an "unclear" type since 0.72.0, and it doesn't do anything in these cases anyway.
mwiencek
force-pushed
the
artist-results-react
branch
from
3475ac2
to
2d4b385
Compare
|
I squashed the commit removing root/search/results-artist.tt into ff68ec6. I didn't remove root/search/lib/inline-results-artist.tt because I believe it's still being used by the taglookup pages. |
yvanzo
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.