Various nixos/gitlab fixes #41495
Various nixos/gitlab fixes #41495
Conversation
The old behaviour caused new instances to be unable to start
It seems like Gitlab doesn't pick up GITLAB_UPLOADS_PATH. The internal uploads
folder is already symlinked to /run/gitlab/uploads by the gitlab package. Here
we symlink this further to ${statePath}/uploads, since /run is (usually) a tmpfs.
|
With these patches it launches and I am able to log in, but actions that require gitaly (such as creating a repository) don't work, because it's unable to connect to the gitaly UDS. |
|
If that can help, I noticed gitaly isn't working to import repos because it seems that rake is not bundled with it. |
|
The issue with Gitaly is that ruby-cd is not wrapped, adding Opened #41566. |
| @@ -560,6 +560,7 @@ in { | |||
| mkdir -p ${cfg.statePath}/tmp/sockets | |||
| mkdir -p ${cfg.statePath}/shell | |||
| mkdir -p ${cfg.statePath}/db | |||
| mkdir -p ${cfg.statePath}/uploads | |||
There was a problem hiding this comment.
Are you sure that this is necessary, as far as I had understood uploads.storage_path = cfg.statePath; in the config above should have made it possible to remove this. How did you trigger an error?
|
I was trying to deploy gitlab today and, besides the problems you had, also got this problem during migration: https://gist.github.com/Denommus/fb595242a9a3f3796b0198d0da56572d#file-journalctl |
|
It seems that with these fixes, somehow, my error also doesn't happen. |
Motivation for this change
Currently Gitlab doesn't even launch properly, because a few paths aren't set up properly. This patch fixes that.
It also disables automatic installation of
pg_trgmif the server isn't set to127.0.0.1(localhost), since thepsqlcalls aren't aware of remote servers (see #41476).Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)