grub: Support when boot.loader.grub.font is null #41486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In order for the grub interface to function properly on the serial console provided by some ARM/aarch64 hardware, the background image and font functionality of Grub must not be used.
The grub module's font type supports being nullable, however the code utilizing the font variable did not accept the null option.
The first commit should be backported, fixing the null option. This will mean that a server where the font has always been null, no font will be loaded.
The second commit would be nice to backport, but I would understand if there is hesitation. This commit would fix systems where a font has been copied in to place, but is no longer desirable after setting font to null.
This behavior is modeled after how the background image is handled. Ideally we would also remove the font / background image, but I'm not sure that should be in scope for this fix.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)cc @dezgeg