fix crash when evaluating return type has compile error

andrewrk · andrewrk · commit 7a0948253636 · 2018-06-05T10:48:53.000-04:00
closes #1058
diff --git a/src/analyze.cpp b/src/analyze.cpp
@@ -1018,6 +1018,8 @@ TypeTableEntry *get_fn_type(CodeGen *g, FnTypeId *fn_type_id) {
     }
     if (fn_type_id->return_type != nullptr) {
         ensure_complete_type(g, fn_type_id->return_type);
+        if (type_is_invalid(fn_type_id->return_type))
+            return g->builtin_types.entry_invalid;
     } else {
         zig_panic("TODO implement inferred return types https://github.com/ziglang/zig/issues/447");
     }
diff --git a/test/compile_errors.zig b/test/compile_errors.zig
@@ -1,6 +1,22 @@
 const tests = @import("tests.zig");
 
 pub fn addCases(cases: *tests.CompileErrorContext) void {
+    cases.add(
+        "error when evaluating return type",
+        \\const Foo = struct {
+        \\    map: i32(i32),
+        \\
+        \\    fn init() Foo {
+        \\        return undefined;
+        \\    }
+        \\};
+        \\export fn entry() void {
+        \\    var rule_set = try Foo.init();
+        \\}
+    ,
+        ".tmp_source.zig:2:13: error: invalid cast from type 'type' to 'i32'",
+    );
+
     cases.add(
         "slicing single-item pointer",
         \\export fn entry(ptr: *i32) void {

Original file line number	Diff line number	Diff line change
`@@ -1018,6 +1018,8 @@ TypeTableEntry get_fn_type(CodeGen g, FnTypeId *fn_type_id) {`
`1018`	`1018`	`}`
`1019`	`1019`	`if (fn_type_id->return_type != nullptr) {`
`1020`	`1020`	`ensure_complete_type(g, fn_type_id->return_type);`
	`1021`	`+ if (type_is_invalid(fn_type_id->return_type))`
	`1022`	`+ return g->builtin_types.entry_invalid;`
`1021`	`1023`	`} else {`
`1022`	`1024`	`zig_panic("TODO implement inferred return types https://github.com/ziglang/zig/issues/447");`
`1023`	`1025`	`}`