Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: ensure parentheses inside assign value. Re-open of #5571 #6163

Merged
merged 1 commit into from Jun 7, 2018
Merged

Compiler: ensure parentheses inside assign value. Re-open of #5571 #6163

merged 1 commit into from Jun 7, 2018

Conversation

splattael
Copy link
Contributor

@splattael splattael commented Jun 5, 2018 •
edited

Fixed conflicts of #5571 as suggested by @RX14

/cc @asterite

Fixes #5568

@splattael
Copy link
Contributor Author

Thanks of approving 💚

Accidentally, I deleted my fork (during some GitHub cleaning) and now I wonder if this PR is still mergeable ❓ 🤔

@ysbaddaden ysbaddaden merged commit 068edc4 into crystal-lang:master Jun 7, 2018
@ysbaddaden
Copy link
Contributor

Yes, it was still mergeable. I guess GitHub creates a local regards of pull requests :-)

@ysbaddaden
Copy link
Contributor

regards -> refs (damn autocorrect).

@RX14 RX14 added this to the 0.25.0 milestone Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler topic:stdlib:macros
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@splattael @ysbaddaden @RX14 @asterite