Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: Fix darwin build #41445

Merged
merged 1 commit into from Jun 4, 2018
Merged

gdal: Fix darwin build #41445

merged 1 commit into from Jun 4, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should fix the darwin build of gdal.
See OSGeo/gdal#573

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp
gdal: Fix darwin build
13e3a21 
This fixes:
  error: cannot initialize a variable of type 'GooString *' with an rvalue of type 'const GooString *'
which occurs with recent clang or gcc-7.
See OSGeo/gdal#573
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gdal

Partial log (click to expand)

shrinking /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/lib/python2.7/site-packages/osgeo/_gdalconst.so
shrinking /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/lib/python2.7/site-packages/osgeo/_gdal.so
shrinking /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/lib/python2.7/site-packages/osgeo/_gdal_array.so
shrinking /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/lib/python2.7/site-packages/osgeo/_ogr.so
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/lib  /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/bin
patching script interpreter paths in /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0
/nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0/bin/gdal-config: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0...
/nix/store/41i8b0jgnm1kb87v84x6yq5rz6vdxci8-gdal-2.3.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gdal

Partial log (click to expand)

       int32       comp_type;    /* compression type */
       ^~~~~
/build/hdf-4.2.13/hdf/src/hproto.h:1954:18: error: unknown type name 'int32'; did you mean 'int'?
                 (int32 vkey, int32 eltpos);
                  ^~~~~
                  int
/build/hdf-4.2.13/hdf/src/hproto.h:1945:29: error: unknown type name 'intn'; did you mean 'int'?
building of '/nix/store/0xmp6938hkam4sfd4i3wn5qd2l4q9qab-hdf-4.2.13.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/7bzh635gzbsx0hvw9vxk942dywjlcvda-gdal-2.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/7bzh635gzbsx0hvw9vxk942dywjlcvda-gdal-2.3.0.drv' failed

LnL7
LnL7 approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit f19e64a into NixOS:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @GrahamcOfBorg @LnL7