Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.vinagre: fix build #41449

Merged
merged 1 commit into from Jun 4, 2018
Merged

gnome3.vinagre: fix build #41449

merged 1 commit into from Jun 4, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 4, 2018

Currently, vinagre fails to build with the following message:

vinagre/vinagre-utils.c: In function 'vinagre_utils_request_credential':
vinagre/vinagre-utils.c:686:2: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
  _tmp12_ = g_strdup_printf (_tmp10_, _tmp11_);
  ^~~~~~~

vinagre-utils.c seems to be generated from vinagre-utils.vala. I
couldn't find anything weird in here, so let's disable
-Werror=format-nonliteral for now as done elsewhere, too.

Motivation for this change

vinagre didn't build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
gnome3.vinagre: fix build
67eaab8 
Currently, vinagre fails to build with the following message:

vinagre/vinagre-utils.c: In function 'vinagre_utils_request_credential':
vinagre/vinagre-utils.c:686:2: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
  _tmp12_ = g_strdup_printf (_tmp10_, _tmp11_);
  ^~~~~~~

vinagre-utils.c seems to be generated from vinagre-utils.vala. I
couldn't find anything weird in here, so let's disable
-Werror=format-nonliteral for now as done elsewhere, too.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jun 4, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.vinagre

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.vinagre

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yjs836mp5wlccd4smv1grqh6wfh8jqms-vinagre-3.22.0
shrinking /nix/store/yjs836mp5wlccd4smv1grqh6wfh8jqms-vinagre-3.22.0/bin/.vinagre-wrapped
gzipping man pages under /nix/store/yjs836mp5wlccd4smv1grqh6wfh8jqms-vinagre-3.22.0/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yjs836mp5wlccd4smv1grqh6wfh8jqms-vinagre-3.22.0/bin
patching script interpreter paths in /nix/store/yjs836mp5wlccd4smv1grqh6wfh8jqms-vinagre-3.22.0
checking for references to /build in /nix/store/yjs836mp5wlccd4smv1grqh6wfh8jqms-vinagre-3.22.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome3.vinagre

Partial log (click to expand)

hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0
shrinking /nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0/bin/.vinagre-wrapped
gzipping man pages under /nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0/bin
patching script interpreter paths in /nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0
checking for references to /build in /nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0...
/nix/store/vxc0lsmlinqmrwsnfkxh5s6qnnar3zz4-vinagre-3.22.0

@flokli
Copy link
Contributor Author

flokli commented Jun 4, 2018

cc @peterhoeg

LnL7
LnL7 approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LnL7 LnL7 merged commit 0b458a4 into NixOS:master Jun 4, 2018
@flokli flokli deleted the vinagre-build branch June 4, 2018 19:48
orivej referenced this pull request Jun 4, 2018
@matthewbauer
vinagre: disable format hardening
f34b498 
https://hydra.nixos.org/build/75464534/nixlog/1
orivej added a commit that referenced this pull request Jun 4, 2018
@orivej
Revert "vinagre: disable format hardening"
8414fa2 
This reverts commit f34b498.

It did not fix the build error in https://hydra.nixos.org/build/75464534/nixlog,
but #41449 did.
@infinisil
Copy link
Member

The same fix was necessary for dxx-rebirth: effbf00

Error was

similar/main/newdemo.cpp:3880:67: error: format not a string literal, format string not checked [-Werror=format-nonliteral]
    auto a = strftime(&filename[i], sizeof(filename) - i, sbuf, ptm);

But hardeningDisable = [ "format" ] didn't work, NIX_CFLAGS_COMPILE = "-Wno-format-nonliteral"; did however. Not sure why.

@LnL7
Copy link
Member

LnL7 commented Jul 21, 2018

Maybe the build itself enables format warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @GrahamcOfBorg @infinisil @LnL7