Add File.same?(path1, path2) with follow_symlinks option #6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
force-pushed
the
fix/file-info-equality
branch
from
05b4431
to
4cf4ed8
Compare
bcardiff
changed the title
sdogruyol
approved these changes
Jun 4, 2018
RX14
requested changes
Jun 4, 2018
| @@ -54,7 +54,7 @@ struct Crystal::System::FileInfo < ::File::Info | |||
| @stat.st_gid.to_u32 | |||
| end | |||
|
|
|||
| def ==(other : ::File::Info) : Bool | |||
| def same_file?(other : ::File::Info) : Bool | |||
There was a problem hiding this comment.
Can we add a File#== as well, which does info on both file instances and then same_file??
There was a problem hiding this comment.
I don't think the semantic of File#== to compare files is accurate. The file has more state that the file description.
There was a problem hiding this comment.
It shouldn't do. But I guess this is fine for now...
| @@ -54,7 +54,7 @@ struct Crystal::System::FileInfo < ::File::Info | |||
| @stat.st_gid.to_u32 | |||
| end | |||
|
|
|||
| def ==(other : ::File::Info) : Bool | |||
| def same_file?(other : ::File::Info) : Bool | |||
There was a problem hiding this comment.
This now needs an abstract def in src/file/info.cr.
There was a problem hiding this comment.
Updated in the next commit
ysbaddaden
approved these changes
Jun 4, 2018
|
@ysbaddaden I agree, but the rest of the defaults for follow_symlink was true. I thought it was better to keep the same default. |
RX14
approved these changes
Jun 4, 2018
|
Ok, I've changed the default to not follow symlinks. |
RX14
approved these changes
Jun 4, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5584
Add
File.same?(path1, path2)method to check if path refers to same file.Rename the
FileInfo#==toFileInfo#same_file?to have better semantics of comparing inodes.