Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "curl: 7.59.0 -> 7.60.0" #41442

Closed
wants to merge 1 commit into from
Closed

Revert "curl: 7.59.0 -> 7.60.0" #41442

wants to merge 1 commit into from

Conversation

NeQuissimus
Copy link
Member

This reverts commit 44101ee.

I would consider this a temporary fix until a proper solution for #41312 has been found.
Unfortunately, NixOS on master is rather unusable without reverting the above commit.

Motivation for this change

All nix tools appear to be flaky and run into timeouts with curl 7.60.0
See #41312 for more details

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus
Revert "curl: 7.59.0 -> 7.60.0"
abbd876 
This reverts commit 44101ee.

All nix tools appear to be flaky and run into timeouts with curl 7.60.0
See NixOS#41312 for more details
@orivej
Copy link
Contributor

orivej commented Jun 4, 2018

You can avoid the mass rebuild by introducing curl_7_59 and using it for Nix. Have you tested that the downgrade helps?

@NeQuissimus
Copy link
Member Author

The downgrade does help. I like that idea, will send a new PR

@NeQuissimus NeQuissimus closed this Jun 4, 2018
@NeQuissimus NeQuissimus deleted the undo_curl branch June 4, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @orivej @GrahamcOfBorg