Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix opam tool support #41461

Merged
merged 1 commit into from Jun 8, 2018
Merged

fix opam tool support #41461

merged 1 commit into from Jun 8, 2018

Conversation

xplat
Copy link
Contributor

@xplat xplat commented Jun 4, 2018

Motivation for this change

opam extension tools like 'opam depext' don't work because of interaction of wrap-program with ocaml/opam#2142 ...

Things done

Changed wrap-program to a more explicit makeWrapper use that avoids using an absolute path for argv0.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants