Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: 3.18.3 -> 3.18.5 #41954

Merged
merged 1 commit into from Jun 29, 2018
Merged

hplip: 3.18.3 -> 3.18.5 #41954

merged 1 commit into from Jun 29, 2018

Conversation

jraygauthier
Copy link
Member

Also fixes multiples issues:

  • broken plugins:

    • fax_marvell.so file is not present or symbolic link is missing
    • lj.so library file doesn't have user/group execute permission.
    • bb_escl.so file is not present or symbolic link is missing

  • multiple error during configuration phase which prevented *.ppd
    generation:

    • ppdc: Unable to find include file "<font.defs>"
    • patched configure time perl script
    • patched use of file

  • some potentially problematic filter and services:

    • patched reference to ghost script and fonts dir in filter.
    • patched usb configuration service.

  • patch scripts so that they refer to valid location.

Add some options:

  • withStaticPPDInstall: Install *.ppd files along with *.drv.
    When true, configure outputs: checking for cups ppd install... yes.
Motivation for this change

Impossible to use my "HP LaserJet 400 colorMFP M475dw" from nixos. Worked fine on Ubuntu.

Improve hp printer support on nixos in general.

Latest version allows for qt5 hp-diagnose_plugin -g. Was only possible in previous version with qt4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested succesfully multiple executables:

  • hp-diagnose_plugin -g
  • hp-diagnose_queues -g
  • hp-setup

Might be a good thing to backport to stable.

@jraygauthier
hplip: 3.18.3 -> 3.18.5
4ca2daa 
Also fixes multiples issues:

 -  broken plugins:

     -  `fax_marvell.so file is not present or symbolic link is missing`
     -  `lj.so library file doesn't have user/group execute permission.`
     -  `bb_escl.so file is not present or symbolic link is missing`

 -  multiple error during configuration phase which prevented `*.ppd`
    generation:

     -  `ppdc: Unable to find include file "<font.defs>"`
     -  patched configure time `perl` script
     -  patched use of `file`

 -  some potentially problematic filter and services:

     -  patched reference to ghost script and fonts dir in filter.
     -  patched usb configuration service.

 -  patch scripts so that they refer to valid location.

Add some options:

 -  `withStaticPPDInstall`: Install `*.ppd` files along with `*.drv`.
    When true, configure outputs: `checking for cups ppd install... yes`.
@FRidh FRidh self-assigned this Jun 29, 2018
@FRidh
Copy link
Member

FRidh commented Jun 29, 2018

@GrahamcOfBorg build hplip hplipWithPlugin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: hplip, hplipWithPlugin

Partial log (click to expand)

  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `hplipWithPlugin' because:
�[31;1merror:�[0m while evaluating 'override' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:78:20, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:21051:21:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:78:29:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/misc/drivers/hplip/default.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:74:12:
HPLIP not supported on x86_64-darwin

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: hplip, hplipWithPlugin

Partial log (click to expand)

  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `hplipWithPlugin' because:
error: while evaluating 'override' at /var/lib/gc-of-borg/nix-test-rs-22/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-22/lib/customisation.nix:78:20, called from /var/lib/gc-of-borg/nix-test-rs-22/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-22/pkgs/top-level/all-packages.nix:21051:21:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-test-rs-22/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-22/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/nix-test-rs-22/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-22/lib/customisation.nix:78:29:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-22/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-22/pkgs/misc/drivers/hplip/default.nix:1:1, called from /var/lib/gc-of-borg/nix-test-rs-22/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-22/lib/customisation.nix:74:12:
HPLIP not supported on aarch64-linux

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hplip

The following builds were skipped because they don't evaluate on x86_64-linux: hplipWithPlugin

Partial log (click to expand)

/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/testpage.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/timedate.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/toolbox.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/uninstall.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/unload.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/upgrade.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5/share/hplip/wificonfig.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/d3aa78jf7pm9lk6ad67x4f21a068dxn6-python-2.7.15/bin/python"
checking for references to /build in /nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5...
postPatchMkspecs
/nix/store/ghw5p5brzmfssvs945gkm6qkada349dy-hplip-3.18.5

@FRidh FRidh merged commit 8be25ff into NixOS:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jraygauthier @FRidh @GrahamcOfBorg