Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin stdenv: fix llvmPackages overrides #41946

Merged
merged 1 commit into from Jun 13, 2018
Merged

darwin stdenv: fix llvmPackages overrides #41946

merged 1 commit into from Jun 13, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

It may seem nice and abstract to just override the default version, but that breaks the alias relationship where the original llvmPackages_* is no longer in sync. Put another away, modifying the referee rather instead of breaking the reference "copy-on-write" is impossible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
darwin stdenv: fix llvmPackage overrides
d7895c2 
It may seem nice and abstract to just override the default version, but
that breaks the alias relationship where the original llvmPackages_* is
no longer in sync. Put another away, modifying the referee rather
instead of breaking the reference "copy-on-write" is impossible.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Jun 13, 2018
@Ericson2314 Ericson2314 changed the title darwin stdenv: fix llvmPackage overrides darwin stdenv: fix llvmPackages overrides Jun 13, 2018
@Ericson2314 Ericson2314 merged commit bce38f4 into NixOS:master Jun 13, 2018
@Ericson2314 Ericson2314 deleted the darwin-booting-llvm branch June 13, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg