Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: be Python version agnostic #41976

Merged
merged 1 commit into from Jun 14, 2018
Merged

salt: be Python version agnostic #41976

merged 1 commit into from Jun 14, 2018

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

As of Salt 2017.7 (Salt Nitrogen), Salt supports Python 3.
Release notes: https://docs.saltstack.com/en/develop/topics/releases/2017.7.0.html#python-3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@aneeshusa
salt: be Python version agnostic
f6f0320 
As of Salt 2017.7 (Salt Nitrogen), Salt supports Python 3.
Release notes: https://docs.saltstack.com/en/develop/topics/releases/2017.7.0.html#python-3
@aneeshusa
Copy link
Contributor Author

cc @FRidh re: #18185

@FRidh
Copy link
Member

FRidh commented Jun 14, 2018

Thanks.

My intention was indeed to remove the version number in case it works with both 2 and 3. However, the migration path which is the motivation for this hasn't quite been accepted.

@FRidh FRidh merged commit a4e59ca into NixOS:master Jun 14, 2018
@FRidh
Copy link
Member

FRidh commented Jun 14, 2018

Even so, the changes are an improvement.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: salt

Partial log (click to expand)

wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-master'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/spm'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-call'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-proxy'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-syndic'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-cloud'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-key'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-cp'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt'...
wrapping `/nix/store/y8db7fwxd068j8z2bsg5yzg00652whjh-salt-2018.3.0/bin/salt-unity'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: salt

Partial log (click to expand)

wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-cp'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-api'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-call'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-key'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-minion'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-cloud'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-run'...
wrapping `/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0/bin/salt-proxy'...
/nix/store/fwcz0gq3r9nclyspfbhjyv2vhrg09rgc-salt-2018.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: salt

Partial log (click to expand)

wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-proxy'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-run'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-minion'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-master'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-syndic'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-call'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-cloud'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-key'...
wrapping `/nix/store/232gpxzmkr95k6b3qi78z0l0xq6703rn-salt-2018.3.0/bin/salt-cp'...

@aneeshusa aneeshusa deleted the make-salt-agnostic-to-python-version branch January 7, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aneeshusa @FRidh @GrahamcOfBorg