Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singularity-tools: create mount points for image building #41470

Merged
merged 1 commit into from Jun 18, 2018
Merged

singularity-tools: create mount points for image building #41470

merged 1 commit into from Jun 18, 2018

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Jun 5, 2018

Motivation for this change

Image build was broken with latest verion of singularity due to missing mount points.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jbedo
Copy link
Contributor Author

jbedo commented Jun 15, 2018

Would be nice to have this merged; any feedback?

@xeji xeji merged commit 1e0a2ea into NixOS:master Jun 18, 2018
@jbedo jbedo deleted the singularity branch July 25, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbedo @GrahamcOfBorg @xeji