pythonPackages.aws-sam-translator: init at 1.5.4 #41474

andreabedini · 2018-06-05T05:57:45Z

Motivation for this change

New python package, needed for aws-sam-cli which I am about to submit as well.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda

Please create a separate commit that adds you to maintainer-list.nix and name the second commit exactly as this PR.

dotlambda · 2018-06-07T09:13:13Z

pkgs/development/python-modules/aws-sam-translator/default.nix

+    sha256 = "9d8a25e058c78d2cef5c07aec7f98cbc2070dbfc2eb6a2e102a16beafd14e3ca";
+  };
+
+  # Tests are not included in the PyPI package


You may want to use fetchFromGitHub in that case.

I looked into it but the versions don't line up, latest tag on GitHub is 1.5 but latest version on PyPi is 1.5.4. The released version is probably just master but they really should tag it.

Well, then better stick with fetchPypi.

dotlambda · 2018-06-07T09:13:37Z

pkgs/development/python-modules/aws-sam-translator/default.nix

+  ];
+
+  meta = {
+    homepage = https://github.com/awslabs/aws-sam-cli;


https://github.com/awslabs/serverless-application-model

upsie! fixed

andreabedini · 2018-06-07T14:06:51Z

Rebased to split d3953f8 into two separate commits.

dotlambda · 2018-06-07T15:00:14Z

The commit messages still need to be changed.

dotlambda · 2018-06-07T15:00:47Z

@GrahamcOfBorg build python2.pkgs.aws-sam-translator python3.pkgs.aws-sam-translator

GrahamcOfBorg · 2018-06-07T15:01:24Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.aws-sam-translator, python3.pkgs.aws-sam-translator

Partial log (click to expand)

strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4/lib
Processing ./aws_sam_translator-1.5.4-py3-none-any.whl
patching script interpreter paths in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4
checking for references to /build in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4...
Collecting enum34~=1.1 (from aws-sam-translator==1.5.4)
  Could not find a version that satisfies the requirement enum34~=1.1 (from aws-sam-translator==1.5.4) (from versions: )
No matching distribution found for enum34~=1.1 (from aws-sam-translator==1.5.4)
builder for '/nix/store/m0vzprvl7040c8rx7nvq7b3cggv09gxh-python3.6-aws-sam-translator-1.5.4.drv' failed with exit code 1
error: build of '/nix/store/m0vzprvl7040c8rx7nvq7b3cggv09gxh-python3.6-aws-sam-translator-1.5.4.drv' failed

GrahamcOfBorg · 2018-06-07T15:01:42Z

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.aws-sam-translator, python3.pkgs.aws-sam-translator

Partial log (click to expand)

removing build/bdist.linux-x86_64/wheel
installing
/build/aws-sam-translator-1.5.4/dist /build/aws-sam-translator-1.5.4
Processing ./aws_sam_translator-1.5.4-py3-none-any.whl
Requirement already satisfied: boto3~=1.5 in /nix/store/842ckc8qqrm7fx90wywncc5cdmb1m7an-python3.6-boto3-1.7.9/lib/python3.6/site-packages (from aws-sam-translator==1.5.4) (1.7.9)
Collecting enum34~=1.1 (from aws-sam-translator==1.5.4)
  Could not find a version that satisfies the requirement enum34~=1.1 (from aws-sam-translator==1.5.4) (from versions: )
No matching distribution found for enum34~=1.1 (from aws-sam-translator==1.5.4)
builder for '/nix/store/ys3qdlc5vj2xzhvfig08b3z4x3rhcflq-python3.6-aws-sam-translator-1.5.4.drv' failed with exit code 1
error: build of '/nix/store/ys3qdlc5vj2xzhvfig08b3z4x3rhcflq-python3.6-aws-sam-translator-1.5.4.drv' failed

dotlambda · 2018-06-07T15:09:06Z

Could not find a version that satisfies the requirement enum34~=1.1

enum34 is probably a python3-only dependency

FRidh

@dotlambda

Python 3.4 Enum backported to 3.3, 3.2, 3.1, 2.7, 2.6, 2.5, and 2.4

FRidh · 2018-06-07T16:15:26Z

pkgs/development/python-modules/aws-sam-translator/default.nix

+
+  propagatedBuildInputs = [
+    boto3
+    enum34


enum34 should be added conditionally, that is, only with Python 2.

I don't think this package supports Python3 at all, I need to express it somewhere

@andreabedini use disabled = isPy3k;

andreabedini · 2018-06-08T03:52:10Z

The commit messages still need to be changed.

sorry @dotlambda I'm not sure how they should be changed, is it documented in the docs? I'll check again

dotlambda · 2018-06-11T14:44:07Z

@GrahamcOfBorg build python2.pkgs.aws-sam-translator python3.pkgs.aws-sam-translator

GrahamcOfBorg · 2018-06-11T14:44:35Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.aws-sam-translator

The following builds were skipped because they don't evaluate on x86_64-linux: python3.pkgs.aws-sam-translator

Partial log (click to expand)

error: while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:113:35, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/top-level/python-packages.nix:202:24:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:117:8:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/development/python-modules/aws-sam-translator/default.nix:1:1, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:74:12:
while evaluating 'makeOverridablePythonPackage' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/top-level/python-packages.nix:40:37, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/development/python-modules/aws-sam-translator/default.nix:11:1:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/top-level/python-packages.nix:42:12:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/development/interpreters/python/build-python-package.nix:27:1, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/lib/customisation.nix:74:12:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/development/interpreters/python/mk-python-derivation.nix:15:1, called from /var/lib/gc-of-borg/nix-root/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/gleber-bastion/pkgs/development/interpreters/python/build-python-package.nix:44:4:
aws-sam-translator-1.5.4 not supported for interpreter python3.6m

/nix/store/sz3fpvsay2h5928v177l18zd05ynlv3l-python2.7-aws-sam-translator-1.5.4

GrahamcOfBorg · 2018-06-11T14:44:42Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.aws-sam-translator

The following builds were skipped because they don't evaluate on aarch64-linux: python3.pkgs.aws-sam-translator

Partial log (click to expand)

Installing collected packages: aws-sam-translator
Successfully installed aws-sam-translator-1.5.4
/build/aws-sam-translator-1.5.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4/lib
patching script interpreter paths in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4
checking for references to /build in /nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4...
/nix/store/lwhd7fp745z3v2z13ivdgbfyy2mvmdvk-python2.7-aws-sam-translator-1.5.4

andreabedini requested a review from FRidh as a code owner June 5, 2018 05:57

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 5, 2018

dotlambda changed the title ~~pythonPackage.aws-sam-translator: init -> 1.5.4~~ pythonPackages.aws-sam-translator: init at 1.5.4 Jun 7, 2018

dotlambda requested changes Jun 7, 2018

View reviewed changes

andreabedini force-pushed the aws-sam-translator branch from d3953f8 to d0266a4 Compare June 7, 2018 14:06

FRidh requested changes Jun 7, 2018

View reviewed changes

Andrea Bedini added 2 commits June 11, 2018 21:15

andreabedini: adding myself as a maintainer

9f7cb7d

pythonPackage.aws-sam-translator: init -> 1.5.4

b7a6dbe

andreabedini force-pushed the aws-sam-translator branch from d0266a4 to b7a6dbe Compare June 11, 2018 13:16

dotlambda merged commit 1b452e4 into NixOS:master Jun 11, 2018

andreabedini deleted the aws-sam-translator branch June 12, 2018 04:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.aws-sam-translator: init at 1.5.4 #41474

pythonPackages.aws-sam-translator: init at 1.5.4 #41474

andreabedini commented Jun 5, 2018 •

edited

dotlambda left a comment

dotlambda Jun 7, 2018

andreabedini Jun 7, 2018

dotlambda Jun 7, 2018

dotlambda Jun 7, 2018

andreabedini Jun 7, 2018

andreabedini commented Jun 7, 2018

dotlambda commented Jun 7, 2018

dotlambda commented Jun 7, 2018

GrahamcOfBorg commented Jun 7, 2018

GrahamcOfBorg commented Jun 7, 2018

dotlambda commented Jun 7, 2018

FRidh left a comment

FRidh Jun 7, 2018

andreabedini Jun 8, 2018

PsyanticY Jun 10, 2018

andreabedini commented Jun 8, 2018

dotlambda commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

pythonPackages.aws-sam-translator: init at 1.5.4 #41474

pythonPackages.aws-sam-translator: init at 1.5.4 #41474

Conversation

andreabedini commented Jun 5, 2018 • edited

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreabedini commented Jun 7, 2018

dotlambda commented Jun 7, 2018

dotlambda commented Jun 7, 2018

GrahamcOfBorg commented Jun 7, 2018

GrahamcOfBorg commented Jun 7, 2018

dotlambda commented Jun 7, 2018

FRidh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreabedini commented Jun 8, 2018

dotlambda commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

andreabedini commented Jun 5, 2018 •

edited